Mercurial > hg > orthanc
view Resources/CMake/LuaConfiguration.cmake @ 2248:69b0f4e8a49b
Escape multipart type parameter value in Content-Type header
## Summary
Multipart responses do not quote/escape the value of their type
parameter (the subtype) even though it always contains at least one
special character (the slash "/"), which confuses standard-compliant
HTTP clients.
## Details
The Content-Type header in HTTP is in RFC 7231, Section 3.1.1.5:
https://tools.ietf.org/html/rfc7231#section-3.1.1.5
The section defers to the media type section (3.1.1.1) for the syntax of
the media type:
https://tools.ietf.org/html/rfc7231#section-3.1.1.1
This states that a parameter value can be quoted:
parameter = token "=" ( token / quoted-string )
A parameter value that matches the token production can be transmitted
either as a token or within a quoted-string. The quoted and unquoted
values are equivalent.
Tokens are defined in RFC 7230, Section 3.2.6 (via RFC 7231, appendix
C):
https://tools.ietf.org/html/rfc7231#appendix-C
https://tools.ietf.org/html/rfc7230#section-3.2.6
Here we observe that tokens cannot contain a slash "/" character:
token = 1*tchar
tchar = "!" / "#" / "$" / "%" / "&" / "'" / "*"
/ "+" / "-" / "." / "^" / "_" / "`" / "|" / "~"
/ DIGIT / ALPHA
; any VCHAR, except delimiters
Delimiters are chosen from the set of US-ASCII visual characters not
allowed in a token (DQUOTE and "(),/:;<=>?@[\]{}").
However, the current implementation does not quote/escape the value of
the type parameter:
multipart/related; type=application/dicom
Instead, it should be:
multipart/related; type="application/dicom"
All of this also seems to apply to the MIME Content-Type header
definition, even though it is a little different:
https://www.iana.org/assignments/message-headers
https://tools.ietf.org/html/rfc2045#section-5.1
https://tools.ietf.org/html/rfc2387
author | Thibault Nélis <tn@osimis.io> |
---|---|
date | Mon, 16 Jan 2017 13:07:11 +0100 |
parents | 8b51b133bb8b |
children | 741bb76634d3 |
line wrap: on
line source
if (STATIC_BUILD OR NOT USE_SYSTEM_LUA) SET(LUA_SOURCES_DIR ${CMAKE_BINARY_DIR}/lua-5.1.5) SET(LUA_MD5 "2e115fe26e435e33b0d5c022e4490567") SET(LUA_URL "http://www.orthanc-server.com/downloads/third-party/lua-5.1.5.tar.gz") DownloadPackage(${LUA_MD5} ${LUA_URL} "${LUA_SOURCES_DIR}") add_definitions( #-DLUA_LIB=1 #-Dluaall_c=1 #-DLUA_COMPAT_ALL=1 # Compile a generic version of Lua ) include_directories( ${LUA_SOURCES_DIR}/src ) set(LUA_SOURCES # Core Lua ${LUA_SOURCES_DIR}/src/lapi.c ${LUA_SOURCES_DIR}/src/lcode.c ${LUA_SOURCES_DIR}/src/ldebug.c ${LUA_SOURCES_DIR}/src/ldo.c ${LUA_SOURCES_DIR}/src/ldump.c ${LUA_SOURCES_DIR}/src/lfunc.c ${LUA_SOURCES_DIR}/src/lgc.c ${LUA_SOURCES_DIR}/src/llex.c ${LUA_SOURCES_DIR}/src/lmem.c ${LUA_SOURCES_DIR}/src/lobject.c ${LUA_SOURCES_DIR}/src/lopcodes.c ${LUA_SOURCES_DIR}/src/lparser.c ${LUA_SOURCES_DIR}/src/lstate.c ${LUA_SOURCES_DIR}/src/lstring.c ${LUA_SOURCES_DIR}/src/ltable.c ${LUA_SOURCES_DIR}/src/ltm.c ${LUA_SOURCES_DIR}/src/lundump.c ${LUA_SOURCES_DIR}/src/lvm.c ${LUA_SOURCES_DIR}/src/lzio.c # Base Lua modules ${LUA_SOURCES_DIR}/src/lauxlib.c ${LUA_SOURCES_DIR}/src/lbaselib.c ${LUA_SOURCES_DIR}/src/ldblib.c ${LUA_SOURCES_DIR}/src/liolib.c ${LUA_SOURCES_DIR}/src/lmathlib.c ${LUA_SOURCES_DIR}/src/loslib.c ${LUA_SOURCES_DIR}/src/ltablib.c ${LUA_SOURCES_DIR}/src/lstrlib.c ${LUA_SOURCES_DIR}/src/loadlib.c ${LUA_SOURCES_DIR}/src/linit.c ) source_group(ThirdParty\\Lua REGULAR_EXPRESSION ${LUA_SOURCES_DIR}/.*) else() include(FindLua51) if (NOT LUA51_FOUND) message(FATAL_ERROR "Please install the liblua-dev package") endif() include_directories(${LUA_INCLUDE_DIR}) link_libraries(${LUA_LIBRARIES}) endif()