diff OrthancFramework/Sources/DicomNetworking/Internals/GetScp.cpp @ 4200:7112a8af0b63

cppcheck
author Sebastien Jodogne <s.jodogne@gmail.com>
date Wed, 16 Sep 2020 20:53:31 +0200
parents 6774605d4341
children 6f5d4bfb2c90
line wrap: on
line diff
--- a/OrthancFramework/Sources/DicomNetworking/Internals/GetScp.cpp	Wed Sep 16 20:28:20 2020 +0200
+++ b/OrthancFramework/Sources/DicomNetworking/Internals/GetScp.cpp	Wed Sep 16 20:53:31 2020 +0200
@@ -100,11 +100,12 @@
       std::string calledAet_;
       int timeout_;
 
-      GetScpData()
+      GetScpData() :
+        handler_(NULL),
+        lastRequest_(NULL),
+        assoc_(NULL),
+        timeout_(0)
       {
-        handler_ = NULL;
-        lastRequest_ = NULL;
-        assoc_ = NULL;
       };
     };
       
@@ -248,9 +249,9 @@
                                 T_DIMSE_Message * msg, 
                                 T_ASC_PresentationContextID presID,
                                 IGetRequestHandler& handler,
-                                std::string remoteIp,
-                                std::string remoteAet,
-                                std::string calledAet,
+                                const std::string& remoteIp,
+                                const std::string& remoteAet,
+                                const std::string& calledAet,
                                 int timeout)
   {
     GetScpData data;