Mercurial > hg > orthanc
diff OrthancFramework/Sources/DicomFormat/DicomMap.cpp @ 5175:48005e522bd6
start fixing thread safety issues with DicomMap
author | Sebastien Jodogne <s.jodogne@gmail.com> |
---|---|
date | Fri, 24 Mar 2023 19:00:33 +0100 |
parents | ea9e2680da6f |
children | 6d8647122ef3 |
line wrap: on
line diff
--- a/OrthancFramework/Sources/DicomFormat/DicomMap.cpp Wed Mar 22 08:26:41 2023 +0100 +++ b/OrthancFramework/Sources/DicomFormat/DicomMap.cpp Fri Mar 24 19:00:33 2023 +0100 @@ -139,8 +139,6 @@ class DicomMap::MainDicomTagsConfiguration { private: - friend DicomMap; - std::set<DicomTag> patientsMainDicomTagsByLevel_; std::set<DicomTag> studiesMainDicomTagsByLevel_; std::set<DicomTag> seriesMainDicomTagsByLevel_; @@ -156,27 +154,6 @@ ResetDefaultMainDicomTags(); } - void ResetDefaultMainDicomTags() - { - patientsMainDicomTagsByLevel_.clear(); - studiesMainDicomTagsByLevel_.clear(); - seriesMainDicomTagsByLevel_.clear(); - instancesMainDicomTagsByLevel_.clear(); - - allMainDicomTags_.clear(); - - // by default, initialize with the previous static list (up to 1.10.0) - LoadDefaultMainDicomTags(ResourceType_Patient); - LoadDefaultMainDicomTags(ResourceType_Study); - LoadDefaultMainDicomTags(ResourceType_Series); - LoadDefaultMainDicomTags(ResourceType_Instance); - - defaultSignatures_[ResourceType_Patient] = signatures_[ResourceType_Patient]; - defaultSignatures_[ResourceType_Study] = signatures_[ResourceType_Study]; - defaultSignatures_[ResourceType_Series] = signatures_[ResourceType_Series]; - defaultSignatures_[ResourceType_Instance] = signatures_[ResourceType_Instance]; - } - std::string ComputeSignature(const std::set<DicomTag>& tags) { // std::set are sorted by default (which is important for us !) @@ -229,29 +206,6 @@ { AddMainDicomTag(tags[i], level); } - - } - - - std::set<DicomTag>& GetMainDicomTagsByLevel(ResourceType level) - { - switch (level) - { - case ResourceType_Patient: - return patientsMainDicomTagsByLevel_; - - case ResourceType_Study: - return studiesMainDicomTagsByLevel_; - - case ResourceType_Series: - return seriesMainDicomTagsByLevel_; - - case ResourceType_Instance: - return instancesMainDicomTagsByLevel_; - - default: - throw OrthancException(ErrorCode_InternalError); - } } public: @@ -262,6 +216,27 @@ return parameters; } + void ResetDefaultMainDicomTags() + { + patientsMainDicomTagsByLevel_.clear(); + studiesMainDicomTagsByLevel_.clear(); + seriesMainDicomTagsByLevel_.clear(); + instancesMainDicomTagsByLevel_.clear(); + + allMainDicomTags_.clear(); + + // by default, initialize with the previous static list (up to 1.10.0) + LoadDefaultMainDicomTags(ResourceType_Patient); + LoadDefaultMainDicomTags(ResourceType_Study); + LoadDefaultMainDicomTags(ResourceType_Series); + LoadDefaultMainDicomTags(ResourceType_Instance); + + defaultSignatures_[ResourceType_Patient] = signatures_[ResourceType_Patient]; + defaultSignatures_[ResourceType_Study] = signatures_[ResourceType_Study]; + defaultSignatures_[ResourceType_Series] = signatures_[ResourceType_Series]; + defaultSignatures_[ResourceType_Instance] = signatures_[ResourceType_Instance]; + } + void AddMainDicomTag(const DicomTag& tag, ResourceType level) { const std::set<DicomTag>& existingLevelTags = GetMainDicomTagsByLevel(level); @@ -296,6 +271,26 @@ return defaultSignatures_[level]; } + std::set<DicomTag>& GetMainDicomTagsByLevel(ResourceType level) + { + switch (level) + { + case ResourceType_Patient: + return patientsMainDicomTagsByLevel_; + + case ResourceType_Study: + return studiesMainDicomTagsByLevel_; + + case ResourceType_Series: + return seriesMainDicomTagsByLevel_; + + case ResourceType_Instance: + return instancesMainDicomTagsByLevel_; + + default: + throw OrthancException(ErrorCode_InternalError); + } + } }; @@ -706,9 +701,10 @@ } - const std::set<DicomTag>& DicomMap::GetMainDicomTags(ResourceType level) + void DicomMap::GetMainDicomTags(std::set<DicomTag>& target, + ResourceType level) { - return DicomMap::MainDicomTagsConfiguration::GetInstance().GetMainDicomTagsByLevel(level); + target = DicomMap::MainDicomTagsConfiguration::GetInstance().GetMainDicomTagsByLevel(level); } const std::set<DicomTag>& DicomMap::GetAllMainDicomTags()