Mercurial > hg > orthanc
diff OrthancServer/Plugins/Engine/OrthancPluginDatabase.cpp @ 4204:318c16cfccab
cppcheck
author | Sebastien Jodogne <s.jodogne@gmail.com> |
---|---|
date | Thu, 17 Sep 2020 16:18:01 +0200 |
parents | 05b8fd21089c |
children | 1bd14c900699 |
line wrap: on
line diff
--- a/OrthancServer/Plugins/Engine/OrthancPluginDatabase.cpp Thu Sep 17 15:01:31 2020 +0200 +++ b/OrthancServer/Plugins/Engine/OrthancPluginDatabase.cpp Thu Sep 17 16:18:01 2020 +0200 @@ -62,22 +62,22 @@ } public: - Transaction(OrthancPluginDatabase& that) : - that_(that) + explicit Transaction(OrthancPluginDatabase& that) : + that_(that) { } - virtual void Begin() + virtual void Begin() ORTHANC_OVERRIDE { CheckSuccess(that_.backend_.startTransaction(that_.payload_)); } - virtual void Rollback() + virtual void Rollback() ORTHANC_OVERRIDE { CheckSuccess(that_.backend_.rollbackTransaction(that_.payload_)); } - virtual void Commit(int64_t diskSizeDelta) + virtual void Commit(int64_t diskSizeDelta) ORTHANC_OVERRIDE { if (that_.fastGetTotalSize_) { @@ -229,7 +229,10 @@ errorDictionary_(errorDictionary), backend_(backend), payload_(payload), - listener_(NULL) + listener_(NULL), + fastGetTotalSize_(false), + currentDiskSize_(0), + answerDoneIgnored_(false) { static const char* const MISSING = " Missing extension in database index plugin: "; @@ -571,11 +574,11 @@ void OrthancPluginDatabase::GetLastChange(std::list<ServerIndexChange>& target /*out*/) { - bool ignored = false; + answerDoneIgnored_ = false; ResetAnswers(); answerChanges_ = ⌖ - answerDone_ = &ignored; + answerDone_ = &answerDoneIgnored_; CheckSuccess(backend_.getLastChange(GetContext(), payload_)); } @@ -583,11 +586,11 @@ void OrthancPluginDatabase::GetLastExportedResource(std::list<ExportedResource>& target /*out*/) { - bool ignored = false; + answerDoneIgnored_ = false; ResetAnswers(); answerExportedResources_ = ⌖ - answerDone_ = &ignored; + answerDone_ = &answerDoneIgnored_; CheckSuccess(backend_.getLastExportedResource(GetContext(), payload_)); }