comparison OrthancFramework/UnitTestsSources/DicomMapTests.cpp @ 4057:8b7cd69806f2 framework

move DicomMapTests from OrthancServer to OrthancFramework
author Sebastien Jodogne <s.jodogne@gmail.com>
date Thu, 11 Jun 2020 13:55:25 +0200
parents OrthancServer/UnitTestsSources/DicomMapTests.cpp@05b8fd21089c
children 0953b3dc3261
comparison
equal deleted inserted replaced
4056:55727d85f419 4057:8b7cd69806f2
1 /**
2 * Orthanc - A Lightweight, RESTful DICOM Store
3 * Copyright (C) 2012-2016 Sebastien Jodogne, Medical Physics
4 * Department, University Hospital of Liege, Belgium
5 * Copyright (C) 2017-2020 Osimis S.A., Belgium
6 *
7 * This program is free software: you can redistribute it and/or
8 * modify it under the terms of the GNU General Public License as
9 * published by the Free Software Foundation, either version 3 of the
10 * License, or (at your option) any later version.
11 *
12 * In addition, as a special exception, the copyright holders of this
13 * program give permission to link the code of its release with the
14 * OpenSSL project's "OpenSSL" library (or with modified versions of it
15 * that use the same license as the "OpenSSL" library), and distribute
16 * the linked executables. You must obey the GNU General Public License
17 * in all respects for all of the code used other than "OpenSSL". If you
18 * modify file(s) with this exception, you may extend this exception to
19 * your version of the file(s), but you are not obligated to do so. If
20 * you do not wish to do so, delete this exception statement from your
21 * version. If you delete this exception statement from all source files
22 * in the program, then also delete it here.
23 *
24 * This program is distributed in the hope that it will be useful, but
25 * WITHOUT ANY WARRANTY; without even the implied warranty of
26 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
27 * General Public License for more details.
28 *
29 * You should have received a copy of the GNU General Public License
30 * along with this program. If not, see <http://www.gnu.org/licenses/>.
31 **/
32
33
34 #if ORTHANC_UNIT_TESTS_LINK_FRAMEWORK == 1
35 # include <OrthancFramework.h>
36 #endif
37
38 #include "gtest/gtest.h"
39
40 #include "../Sources/Compatibility.h"
41 #include "../Sources/OrthancException.h"
42 #include "../Sources/DicomFormat/DicomMap.h"
43 #include "../Sources/DicomParsing/FromDcmtkBridge.h"
44 #include "../Sources/DicomParsing/ToDcmtkBridge.h"
45 #include "../Sources/DicomParsing/ParsedDicomFile.h"
46 #include "../Sources/DicomParsing/DicomWebJsonVisitor.h"
47
48 #include <memory>
49 #include <dcmtk/dcmdata/dcdeftag.h>
50 #include <dcmtk/dcmdata/dcvrat.h>
51
52 using namespace Orthanc;
53
54 TEST(DicomMap, MainTags)
55 {
56 ASSERT_TRUE(DicomMap::IsMainDicomTag(DICOM_TAG_PATIENT_ID));
57 ASSERT_TRUE(DicomMap::IsMainDicomTag(DICOM_TAG_PATIENT_ID, ResourceType_Patient));
58 ASSERT_FALSE(DicomMap::IsMainDicomTag(DICOM_TAG_PATIENT_ID, ResourceType_Study));
59
60 ASSERT_TRUE(DicomMap::IsMainDicomTag(DICOM_TAG_STUDY_INSTANCE_UID));
61 ASSERT_TRUE(DicomMap::IsMainDicomTag(DICOM_TAG_ACCESSION_NUMBER));
62 ASSERT_TRUE(DicomMap::IsMainDicomTag(DICOM_TAG_SERIES_INSTANCE_UID));
63 ASSERT_TRUE(DicomMap::IsMainDicomTag(DICOM_TAG_SOP_INSTANCE_UID));
64
65 std::set<DicomTag> s;
66 DicomMap::GetMainDicomTags(s);
67 ASSERT_TRUE(s.end() != s.find(DICOM_TAG_PATIENT_ID));
68 ASSERT_TRUE(s.end() != s.find(DICOM_TAG_STUDY_INSTANCE_UID));
69 ASSERT_TRUE(s.end() != s.find(DICOM_TAG_ACCESSION_NUMBER));
70 ASSERT_TRUE(s.end() != s.find(DICOM_TAG_SERIES_INSTANCE_UID));
71 ASSERT_TRUE(s.end() != s.find(DICOM_TAG_SOP_INSTANCE_UID));
72
73 DicomMap::GetMainDicomTags(s, ResourceType_Patient);
74 ASSERT_TRUE(s.end() != s.find(DICOM_TAG_PATIENT_ID));
75 ASSERT_TRUE(s.end() == s.find(DICOM_TAG_STUDY_INSTANCE_UID));
76
77 DicomMap::GetMainDicomTags(s, ResourceType_Study);
78 ASSERT_TRUE(s.end() != s.find(DICOM_TAG_STUDY_INSTANCE_UID));
79 ASSERT_TRUE(s.end() != s.find(DICOM_TAG_ACCESSION_NUMBER));
80 ASSERT_TRUE(s.end() == s.find(DICOM_TAG_PATIENT_ID));
81
82 DicomMap::GetMainDicomTags(s, ResourceType_Series);
83 ASSERT_TRUE(s.end() != s.find(DICOM_TAG_SERIES_INSTANCE_UID));
84 ASSERT_TRUE(s.end() == s.find(DICOM_TAG_PATIENT_ID));
85
86 DicomMap::GetMainDicomTags(s, ResourceType_Instance);
87 ASSERT_TRUE(s.end() != s.find(DICOM_TAG_SOP_INSTANCE_UID));
88 ASSERT_TRUE(s.end() == s.find(DICOM_TAG_PATIENT_ID));
89 }
90
91
92 TEST(DicomMap, Tags)
93 {
94 std::set<DicomTag> s;
95
96 DicomMap m;
97 m.GetTags(s);
98 ASSERT_EQ(0u, s.size());
99
100 ASSERT_FALSE(m.HasTag(DICOM_TAG_PATIENT_NAME));
101 ASSERT_FALSE(m.HasTag(0x0010, 0x0010));
102 m.SetValue(0x0010, 0x0010, "PatientName", false);
103 ASSERT_TRUE(m.HasTag(DICOM_TAG_PATIENT_NAME));
104 ASSERT_TRUE(m.HasTag(0x0010, 0x0010));
105
106 m.GetTags(s);
107 ASSERT_EQ(1u, s.size());
108 ASSERT_EQ(DICOM_TAG_PATIENT_NAME, *s.begin());
109
110 ASSERT_FALSE(m.HasTag(DICOM_TAG_PATIENT_ID));
111 m.SetValue(DICOM_TAG_PATIENT_ID, "PatientID", false);
112 ASSERT_TRUE(m.HasTag(0x0010, 0x0020));
113 m.SetValue(DICOM_TAG_PATIENT_ID, "PatientID2", false);
114 ASSERT_EQ("PatientID2", m.GetValue(0x0010, 0x0020).GetContent());
115
116 m.GetTags(s);
117 ASSERT_EQ(2u, s.size());
118
119 m.Remove(DICOM_TAG_PATIENT_ID);
120 ASSERT_THROW(m.GetValue(0x0010, 0x0020), OrthancException);
121
122 m.GetTags(s);
123 ASSERT_EQ(1u, s.size());
124 ASSERT_EQ(DICOM_TAG_PATIENT_NAME, *s.begin());
125
126 std::unique_ptr<DicomMap> mm(m.Clone());
127 ASSERT_EQ("PatientName", mm->GetValue(DICOM_TAG_PATIENT_NAME).GetContent());
128
129 m.SetValue(DICOM_TAG_PATIENT_ID, "Hello", false);
130 ASSERT_THROW(mm->GetValue(DICOM_TAG_PATIENT_ID), OrthancException);
131 mm->CopyTagIfExists(m, DICOM_TAG_PATIENT_ID);
132 ASSERT_EQ("Hello", mm->GetValue(DICOM_TAG_PATIENT_ID).GetContent());
133
134 DicomValue v;
135 ASSERT_TRUE(v.IsNull());
136 }
137
138
139 TEST(DicomMap, FindTemplates)
140 {
141 DicomMap m;
142
143 DicomMap::SetupFindPatientTemplate(m);
144 ASSERT_TRUE(m.HasTag(DICOM_TAG_PATIENT_ID));
145
146 DicomMap::SetupFindStudyTemplate(m);
147 ASSERT_TRUE(m.HasTag(DICOM_TAG_STUDY_INSTANCE_UID));
148 ASSERT_TRUE(m.HasTag(DICOM_TAG_ACCESSION_NUMBER));
149
150 DicomMap::SetupFindSeriesTemplate(m);
151 ASSERT_TRUE(m.HasTag(DICOM_TAG_SERIES_INSTANCE_UID));
152
153 DicomMap::SetupFindInstanceTemplate(m);
154 ASSERT_TRUE(m.HasTag(DICOM_TAG_SOP_INSTANCE_UID));
155 }
156
157
158
159
160 static void TestModule(ResourceType level,
161 DicomModule module)
162 {
163 // REFERENCE: DICOM PS3.3 2015c - Information Object Definitions
164 // http://dicom.nema.org/medical/dicom/current/output/html/part03.html
165
166 std::set<DicomTag> moduleTags, main;
167 DicomTag::AddTagsForModule(moduleTags, module);
168 DicomMap::GetMainDicomTags(main, level);
169
170 // The main dicom tags are a subset of the module
171 for (std::set<DicomTag>::const_iterator it = main.begin(); it != main.end(); ++it)
172 {
173 bool ok = moduleTags.find(*it) != moduleTags.end();
174
175 // Exceptions for the Study level
176 if (level == ResourceType_Study &&
177 (*it == DicomTag(0x0008, 0x0080) || /* InstitutionName, from Visit identification module, related to Visit */
178 *it == DicomTag(0x0032, 0x1032) || /* RequestingPhysician, from Imaging Service Request module, related to Study */
179 *it == DicomTag(0x0032, 0x1060))) /* RequestedProcedureDescription, from Requested Procedure module, related to Study */
180 {
181 ok = true;
182 }
183
184 // Exceptions for the Series level
185 if (level == ResourceType_Series &&
186 (*it == DicomTag(0x0008, 0x0070) || /* Manufacturer, from General Equipment Module */
187 *it == DicomTag(0x0008, 0x1010) || /* StationName, from General Equipment Module */
188 *it == DicomTag(0x0018, 0x0024) || /* SequenceName, from MR Image Module (SIMPLIFICATION => Series) */
189 *it == DicomTag(0x0018, 0x1090) || /* CardiacNumberOfImages, from MR Image Module (SIMPLIFICATION => Series) */
190 *it == DicomTag(0x0020, 0x0037) || /* ImageOrientationPatient, from Image Plane Module (SIMPLIFICATION => Series) */
191 *it == DicomTag(0x0020, 0x0105) || /* NumberOfTemporalPositions, from MR Image Module (SIMPLIFICATION => Series) */
192 *it == DicomTag(0x0020, 0x1002) || /* ImagesInAcquisition, from General Image Module (SIMPLIFICATION => Series) */
193 *it == DicomTag(0x0054, 0x0081) || /* NumberOfSlices, from PET Series module */
194 *it == DicomTag(0x0054, 0x0101) || /* NumberOfTimeSlices, from PET Series module */
195 *it == DicomTag(0x0054, 0x1000) || /* SeriesType, from PET Series module */
196 *it == DicomTag(0x0018, 0x1400) || /* AcquisitionDeviceProcessingDescription, from CR/X-Ray/DX/WholeSlideMicro Image (SIMPLIFICATION => Series) */
197 *it == DicomTag(0x0018, 0x0010))) /* ContrastBolusAgent, from Contrast/Bolus module (SIMPLIFICATION => Series) */
198 {
199 ok = true;
200 }
201
202 // Exceptions for the Instance level
203 if (level == ResourceType_Instance &&
204 (*it == DicomTag(0x0020, 0x0012) || /* AccessionNumber, from General Image module */
205 *it == DicomTag(0x0054, 0x1330) || /* ImageIndex, from PET Image module */
206 *it == DicomTag(0x0020, 0x0100) || /* TemporalPositionIdentifier, from MR Image module */
207 *it == DicomTag(0x0028, 0x0008) || /* NumberOfFrames, from Multi-frame module attributes, related to Image */
208 *it == DicomTag(0x0020, 0x0032) || /* ImagePositionPatient, from Image Plan module, related to Image */
209 *it == DicomTag(0x0020, 0x0037) || /* ImageOrientationPatient, from Image Plane Module (Orthanc 1.4.2) */
210 *it == DicomTag(0x0020, 0x4000))) /* ImageComments, from General Image module */
211 {
212 ok = true;
213 }
214
215 if (!ok)
216 {
217 std::cout << it->Format() << ": " << FromDcmtkBridge::GetTagName(*it, "")
218 << " not expected at level " << EnumerationToString(level) << std::endl;
219 }
220
221 EXPECT_TRUE(ok);
222 }
223 }
224
225
226 TEST(DicomMap, Modules)
227 {
228 TestModule(ResourceType_Patient, DicomModule_Patient);
229 TestModule(ResourceType_Study, DicomModule_Study);
230 TestModule(ResourceType_Series, DicomModule_Series); // TODO
231 TestModule(ResourceType_Instance, DicomModule_Instance);
232 }
233
234
235 TEST(DicomMap, Parse)
236 {
237 DicomMap m;
238 float f;
239 double d;
240 int32_t i;
241 int64_t j;
242 uint32_t k;
243 uint64_t l;
244 unsigned int ui;
245 std::string s;
246
247 m.SetValue(DICOM_TAG_PATIENT_NAME, " ", false); // Empty value
248 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseFloat(f));
249 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseDouble(d));
250 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger32(i));
251 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger64(j));
252 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger32(k));
253 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger64(l));
254
255 m.SetValue(DICOM_TAG_PATIENT_NAME, "0", true); // Binary value
256 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseFloat(f));
257 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseDouble(d));
258 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger32(i));
259 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger64(j));
260 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger32(k));
261 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger64(l));
262
263 ASSERT_FALSE(m.LookupStringValue(s, DICOM_TAG_PATIENT_NAME, false));
264 ASSERT_TRUE(m.LookupStringValue(s, DICOM_TAG_PATIENT_NAME, true));
265 ASSERT_EQ("0", s);
266
267
268 // 2**31-1
269 m.SetValue(DICOM_TAG_PATIENT_NAME, "2147483647", false);
270 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseFloat(f));
271 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseDouble(d));
272 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger32(i));
273 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger64(j));
274 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger32(k));
275 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger64(l));
276 ASSERT_FLOAT_EQ(2147483647.0f, f);
277 ASSERT_DOUBLE_EQ(2147483647.0, d);
278 ASSERT_EQ(2147483647, i);
279 ASSERT_EQ(2147483647ll, j);
280 ASSERT_EQ(2147483647u, k);
281 ASSERT_EQ(2147483647ull, l);
282
283 // Test shortcuts
284 m.SetValue(DICOM_TAG_PATIENT_NAME, "42", false);
285 ASSERT_TRUE(m.ParseFloat(f, DICOM_TAG_PATIENT_NAME));
286 ASSERT_TRUE(m.ParseDouble(d, DICOM_TAG_PATIENT_NAME));
287 ASSERT_TRUE(m.ParseInteger32(i, DICOM_TAG_PATIENT_NAME));
288 ASSERT_TRUE(m.ParseInteger64(j, DICOM_TAG_PATIENT_NAME));
289 ASSERT_TRUE(m.ParseUnsignedInteger32(k, DICOM_TAG_PATIENT_NAME));
290 ASSERT_TRUE(m.ParseUnsignedInteger64(l, DICOM_TAG_PATIENT_NAME));
291 ASSERT_FLOAT_EQ(42.0f, f);
292 ASSERT_DOUBLE_EQ(42.0, d);
293 ASSERT_EQ(42, i);
294 ASSERT_EQ(42ll, j);
295 ASSERT_EQ(42u, k);
296 ASSERT_EQ(42ull, l);
297
298 ASSERT_TRUE(m.LookupStringValue(s, DICOM_TAG_PATIENT_NAME, false));
299 ASSERT_EQ("42", s);
300 ASSERT_TRUE(m.LookupStringValue(s, DICOM_TAG_PATIENT_NAME, true));
301 ASSERT_EQ("42", s);
302
303
304 // 2**31
305 m.SetValue(DICOM_TAG_PATIENT_NAME, "2147483648", false);
306 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseFloat(f));
307 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseDouble(d));
308 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger32(i));
309 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger64(j));
310 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger32(k));
311 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger64(l));
312 ASSERT_FLOAT_EQ(2147483648.0f, f);
313 ASSERT_DOUBLE_EQ(2147483648.0, d);
314 ASSERT_EQ(2147483648ll, j);
315 ASSERT_EQ(2147483648u, k);
316 ASSERT_EQ(2147483648ull, l);
317
318 // 2**32-1
319 m.SetValue(DICOM_TAG_PATIENT_NAME, "4294967295", false);
320 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseFloat(f));
321 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseDouble(d));
322 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger32(i));
323 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger64(j));
324 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger32(k));
325 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger64(l));
326 ASSERT_FLOAT_EQ(4294967295.0f, f);
327 ASSERT_DOUBLE_EQ(4294967295.0, d);
328 ASSERT_EQ(4294967295ll, j);
329 ASSERT_EQ(4294967295u, k);
330 ASSERT_EQ(4294967295ull, l);
331
332 // 2**32
333 m.SetValue(DICOM_TAG_PATIENT_NAME, "4294967296", false);
334 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseFloat(f));
335 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseDouble(d));
336 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger32(i));
337 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger64(j));
338 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger32(k));
339 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger64(l));
340 ASSERT_FLOAT_EQ(4294967296.0f, f);
341 ASSERT_DOUBLE_EQ(4294967296.0, d);
342 ASSERT_EQ(4294967296ll, j);
343 ASSERT_EQ(4294967296ull, l);
344
345 m.SetValue(DICOM_TAG_PATIENT_NAME, "-1", false);
346 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseFloat(f));
347 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseDouble(d));
348 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger32(i));
349 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger64(j));
350 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger32(k));
351 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger64(l));
352 ASSERT_FLOAT_EQ(-1.0f, f);
353 ASSERT_DOUBLE_EQ(-1.0, d);
354 ASSERT_EQ(-1, i);
355 ASSERT_EQ(-1ll, j);
356
357 // -2**31
358 m.SetValue(DICOM_TAG_PATIENT_NAME, "-2147483648", false);
359 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseFloat(f));
360 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseDouble(d));
361 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger32(i));
362 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger64(j));
363 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger32(k));
364 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger64(l));
365 ASSERT_FLOAT_EQ(-2147483648.0f, f);
366 ASSERT_DOUBLE_EQ(-2147483648.0, d);
367 ASSERT_EQ(static_cast<int32_t>(-2147483648ll), i);
368 ASSERT_EQ(-2147483648ll, j);
369
370 // -2**31 - 1
371 m.SetValue(DICOM_TAG_PATIENT_NAME, "-2147483649", false);
372 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseFloat(f));
373 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseDouble(d));
374 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger32(i));
375 ASSERT_TRUE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseInteger64(j));
376 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger32(k));
377 ASSERT_FALSE(m.GetValue(DICOM_TAG_PATIENT_NAME).ParseUnsignedInteger64(l));
378 ASSERT_FLOAT_EQ(-2147483649.0f, f);
379 ASSERT_DOUBLE_EQ(-2147483649.0, d);
380 ASSERT_EQ(-2147483649ll, j);
381
382
383 // "800\0" in US COLMUNS tag
384 m.SetValue(DICOM_TAG_COLUMNS, "800\0", false);
385 ASSERT_TRUE(m.GetValue(DICOM_TAG_COLUMNS).ParseFirstUnsignedInteger(ui));
386 ASSERT_EQ(800u, ui);
387 m.SetValue(DICOM_TAG_COLUMNS, "800", false);
388 ASSERT_TRUE(m.GetValue(DICOM_TAG_COLUMNS).ParseFirstUnsignedInteger(ui));
389 ASSERT_EQ(800u, ui);
390 }
391
392
393 TEST(DicomMap, Serialize)
394 {
395 Json::Value s;
396
397 {
398 DicomMap m;
399 m.SetValue(DICOM_TAG_PATIENT_NAME, "Hello", false);
400 m.SetValue(DICOM_TAG_STUDY_DESCRIPTION, "Binary", true);
401 m.SetNullValue(DICOM_TAG_SERIES_DESCRIPTION);
402 m.Serialize(s);
403 }
404
405 {
406 DicomMap m;
407 m.Unserialize(s);
408
409 const DicomValue* v = m.TestAndGetValue(DICOM_TAG_ACCESSION_NUMBER);
410 ASSERT_TRUE(v == NULL);
411
412 v = m.TestAndGetValue(DICOM_TAG_PATIENT_NAME);
413 ASSERT_TRUE(v != NULL);
414 ASSERT_FALSE(v->IsNull());
415 ASSERT_FALSE(v->IsBinary());
416 ASSERT_EQ("Hello", v->GetContent());
417
418 v = m.TestAndGetValue(DICOM_TAG_STUDY_DESCRIPTION);
419 ASSERT_TRUE(v != NULL);
420 ASSERT_FALSE(v->IsNull());
421 ASSERT_TRUE(v->IsBinary());
422 ASSERT_EQ("Binary", v->GetContent());
423
424 v = m.TestAndGetValue(DICOM_TAG_SERIES_DESCRIPTION);
425 ASSERT_TRUE(v != NULL);
426 ASSERT_TRUE(v->IsNull());
427 ASSERT_FALSE(v->IsBinary());
428 ASSERT_THROW(v->GetContent(), OrthancException);
429 }
430 }
431
432
433
434 TEST(DicomMap, ExtractMainDicomTags)
435 {
436 DicomMap b;
437 b.SetValue(DICOM_TAG_PATIENT_NAME, "E", false);
438 ASSERT_TRUE(b.HasOnlyMainDicomTags());
439
440 {
441 DicomMap a;
442 a.SetValue(DICOM_TAG_PATIENT_NAME, "A", false);
443 a.SetValue(DICOM_TAG_STUDY_DESCRIPTION, "B", false);
444 a.SetValue(DICOM_TAG_SERIES_DESCRIPTION, "C", false);
445 a.SetValue(DICOM_TAG_NUMBER_OF_FRAMES, "D", false);
446 a.SetValue(DICOM_TAG_SLICE_THICKNESS, "F", false);
447 ASSERT_FALSE(a.HasOnlyMainDicomTags());
448 b.ExtractMainDicomTags(a);
449 }
450
451 ASSERT_EQ(4u, b.GetSize());
452 ASSERT_EQ("A", b.GetValue(DICOM_TAG_PATIENT_NAME).GetContent());
453 ASSERT_EQ("B", b.GetValue(DICOM_TAG_STUDY_DESCRIPTION).GetContent());
454 ASSERT_EQ("C", b.GetValue(DICOM_TAG_SERIES_DESCRIPTION).GetContent());
455 ASSERT_EQ("D", b.GetValue(DICOM_TAG_NUMBER_OF_FRAMES).GetContent());
456 ASSERT_FALSE(b.HasTag(DICOM_TAG_SLICE_THICKNESS));
457 ASSERT_TRUE(b.HasOnlyMainDicomTags());
458
459 b.SetValue(DICOM_TAG_PATIENT_NAME, "G", false);
460
461 {
462 DicomMap a;
463 a.SetValue(DICOM_TAG_PATIENT_NAME, "A", false);
464 a.SetValue(DICOM_TAG_SLICE_THICKNESS, "F", false);
465 ASSERT_FALSE(a.HasOnlyMainDicomTags());
466 b.Merge(a);
467 }
468
469 ASSERT_EQ(5u, b.GetSize());
470 ASSERT_EQ("G", b.GetValue(DICOM_TAG_PATIENT_NAME).GetContent());
471 ASSERT_EQ("B", b.GetValue(DICOM_TAG_STUDY_DESCRIPTION).GetContent());
472 ASSERT_EQ("C", b.GetValue(DICOM_TAG_SERIES_DESCRIPTION).GetContent());
473 ASSERT_EQ("D", b.GetValue(DICOM_TAG_NUMBER_OF_FRAMES).GetContent());
474 ASSERT_EQ("F", b.GetValue(DICOM_TAG_SLICE_THICKNESS).GetContent());
475 ASSERT_FALSE(b.HasOnlyMainDicomTags());
476 }
477
478
479 TEST(DicomMap, RemoveBinary)
480 {
481 DicomMap b;
482 b.SetValue(DICOM_TAG_PATIENT_NAME, "A", false);
483 b.SetValue(DICOM_TAG_PATIENT_ID, "B", true);
484 b.SetValue(DICOM_TAG_STUDY_INSTANCE_UID, DicomValue()); // NULL
485 b.SetValue(DICOM_TAG_SERIES_INSTANCE_UID, DicomValue("C", false));
486 b.SetValue(DICOM_TAG_SOP_INSTANCE_UID, DicomValue("D", true));
487
488 b.RemoveBinaryTags();
489
490 std::string s;
491 ASSERT_EQ(2u, b.GetSize());
492 ASSERT_TRUE(b.LookupStringValue(s, DICOM_TAG_PATIENT_NAME, false)); ASSERT_EQ("A", s);
493 ASSERT_TRUE(b.LookupStringValue(s, DICOM_TAG_SERIES_INSTANCE_UID, false)); ASSERT_EQ("C", s);
494 }
495
496
497
498 TEST(DicomWebJson, Multiplicity)
499 {
500 // http://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_F.2.4.html
501
502 ParsedDicomFile dicom(false);
503 dicom.ReplacePlainString(DICOM_TAG_PATIENT_NAME, "SB1^SB2^SB3^SB4^SB5");
504 dicom.ReplacePlainString(DICOM_TAG_IMAGE_ORIENTATION_PATIENT, "1\\2.3\\4");
505 dicom.ReplacePlainString(DICOM_TAG_IMAGE_POSITION_PATIENT, "");
506
507 DicomWebJsonVisitor visitor;
508 dicom.Apply(visitor);
509
510 {
511 const Json::Value& tag = visitor.GetResult() ["00200037"]; // ImageOrientationPatient
512 const Json::Value& value = tag["Value"];
513
514 ASSERT_EQ(EnumerationToString(ValueRepresentation_DecimalString), tag["vr"].asString());
515 ASSERT_EQ(2u, tag.getMemberNames().size());
516 ASSERT_EQ(3u, value.size());
517 ASSERT_EQ(Json::realValue, value[1].type());
518 ASSERT_FLOAT_EQ(1.0f, value[0].asFloat());
519 ASSERT_FLOAT_EQ(2.3f, value[1].asFloat());
520 ASSERT_FLOAT_EQ(4.0f, value[2].asFloat());
521 }
522
523 {
524 const Json::Value& tag = visitor.GetResult() ["00200032"]; // ImagePositionPatient
525 ASSERT_EQ(EnumerationToString(ValueRepresentation_DecimalString), tag["vr"].asString());
526 ASSERT_EQ(1u, tag.getMemberNames().size());
527 }
528
529 std::string xml;
530 visitor.FormatXml(xml);
531
532 {
533 DicomMap m;
534 m.FromDicomWeb(visitor.GetResult());
535 ASSERT_EQ(3u, m.GetSize());
536
537 std::string s;
538 ASSERT_TRUE(m.LookupStringValue(s, DICOM_TAG_PATIENT_NAME, false));
539 ASSERT_EQ("SB1^SB2^SB3^SB4^SB5", s);
540 ASSERT_TRUE(m.LookupStringValue(s, DICOM_TAG_IMAGE_POSITION_PATIENT, false));
541 ASSERT_TRUE(s.empty());
542
543 ASSERT_TRUE(m.LookupStringValue(s, DICOM_TAG_IMAGE_ORIENTATION_PATIENT, false));
544
545 std::vector<std::string> v;
546 Toolbox::TokenizeString(v, s, '\\');
547 ASSERT_FLOAT_EQ(1.0f, boost::lexical_cast<float>(v[0]));
548 ASSERT_FLOAT_EQ(2.3f, boost::lexical_cast<float>(v[1]));
549 ASSERT_FLOAT_EQ(4.0f, boost::lexical_cast<float>(v[2]));
550 }
551 }
552
553
554 TEST(DicomWebJson, NullValue)
555 {
556 // http://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_F.2.5.html
557
558 ParsedDicomFile dicom(false);
559 dicom.ReplacePlainString(DICOM_TAG_IMAGE_ORIENTATION_PATIENT, "1.5\\\\\\2.5");
560
561 DicomWebJsonVisitor visitor;
562 dicom.Apply(visitor);
563
564 {
565 const Json::Value& tag = visitor.GetResult() ["00200037"];
566 const Json::Value& value = tag["Value"];
567
568 ASSERT_EQ(EnumerationToString(ValueRepresentation_DecimalString), tag["vr"].asString());
569 ASSERT_EQ(2u, tag.getMemberNames().size());
570 ASSERT_EQ(4u, value.size());
571 ASSERT_EQ(Json::realValue, value[0].type());
572 ASSERT_EQ(Json::nullValue, value[1].type());
573 ASSERT_EQ(Json::nullValue, value[2].type());
574 ASSERT_EQ(Json::realValue, value[3].type());
575 ASSERT_FLOAT_EQ(1.5f, value[0].asFloat());
576 ASSERT_FLOAT_EQ(2.5f, value[3].asFloat());
577 }
578
579 std::string xml;
580 visitor.FormatXml(xml);
581
582 {
583 DicomMap m;
584 m.FromDicomWeb(visitor.GetResult());
585 ASSERT_EQ(1u, m.GetSize());
586
587 std::string s;
588 ASSERT_TRUE(m.LookupStringValue(s, DICOM_TAG_IMAGE_ORIENTATION_PATIENT, false));
589
590 std::vector<std::string> v;
591 Toolbox::TokenizeString(v, s, '\\');
592 ASSERT_FLOAT_EQ(1.5f, boost::lexical_cast<float>(v[0]));
593 ASSERT_TRUE(v[1].empty());
594 ASSERT_TRUE(v[2].empty());
595 ASSERT_FLOAT_EQ(2.5f, boost::lexical_cast<float>(v[3]));
596 }
597 }
598
599
600 static void SetTagKey(ParsedDicomFile& dicom,
601 const DicomTag& tag,
602 const DicomTag& value)
603 {
604 // This function emulates a call to function
605 // "dicom.GetDcmtkObject().getDataset()->putAndInsertTagKey(tag,
606 // value)" that was not available in DCMTK 3.6.0
607
608 std::unique_ptr<DcmAttributeTag> element(new DcmAttributeTag(ToDcmtkBridge::Convert(tag)));
609
610 DcmTagKey v = ToDcmtkBridge::Convert(value);
611 if (!element->putTagVal(v).good())
612 {
613 throw OrthancException(ErrorCode_InternalError);
614 }
615
616 dicom.GetDcmtkObject().getDataset()->insert(element.release());
617 }
618
619
620 TEST(DicomWebJson, ValueRepresentation)
621 {
622 // http://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_F.2.3.html
623
624 ParsedDicomFile dicom(false);
625 dicom.ReplacePlainString(DicomTag(0x0040, 0x0241), "AE");
626 dicom.ReplacePlainString(DicomTag(0x0010, 0x1010), "AS");
627 SetTagKey(dicom, DicomTag(0x0020, 0x9165), DicomTag(0x0010, 0x0020));
628 dicom.ReplacePlainString(DicomTag(0x0008, 0x0052), "CS");
629 dicom.ReplacePlainString(DicomTag(0x0008, 0x0012), "DA");
630 dicom.ReplacePlainString(DicomTag(0x0010, 0x1020), "42"); // DS
631 dicom.ReplacePlainString(DicomTag(0x0008, 0x002a), "DT");
632 dicom.ReplacePlainString(DicomTag(0x0010, 0x9431), "43"); // FL
633 dicom.ReplacePlainString(DicomTag(0x0008, 0x1163), "44"); // FD
634 dicom.ReplacePlainString(DicomTag(0x0008, 0x1160), "45"); // IS
635 dicom.ReplacePlainString(DicomTag(0x0008, 0x0070), "LO");
636 dicom.ReplacePlainString(DicomTag(0x0010, 0x4000), "LT");
637 dicom.ReplacePlainString(DicomTag(0x0028, 0x2000), "OB");
638 dicom.ReplacePlainString(DicomTag(0x7fe0, 0x0009), "3.14159"); // OD (other double)
639 dicom.ReplacePlainString(DicomTag(0x0064, 0x0009), "2.71828"); // OF (other float)
640 dicom.ReplacePlainString(DicomTag(0x0066, 0x0040), "46"); // OL (other long)
641 ASSERT_THROW(dicom.ReplacePlainString(DicomTag(0x0028, 0x1201), "O"), OrthancException);
642 dicom.ReplacePlainString(DicomTag(0x0028, 0x1201), "OWOW");
643 dicom.ReplacePlainString(DicomTag(0x0010, 0x0010), "PN");
644 dicom.ReplacePlainString(DicomTag(0x0008, 0x0050), "SH");
645 dicom.ReplacePlainString(DicomTag(0x0018, 0x6020), "-15"); // SL
646 dicom.ReplacePlainString(DicomTag(0x0018, 0x9219), "-16"); // SS
647 dicom.ReplacePlainString(DicomTag(0x0008, 0x0081), "ST");
648 dicom.ReplacePlainString(DicomTag(0x0008, 0x0013), "TM");
649 dicom.ReplacePlainString(DicomTag(0x0008, 0x0119), "UC");
650 dicom.ReplacePlainString(DicomTag(0x0008, 0x0016), "UI");
651 dicom.ReplacePlainString(DicomTag(0x0008, 0x1161), "128"); // UL
652 dicom.ReplacePlainString(DicomTag(0x4342, 0x1234), "UN"); // Inexistent tag
653 dicom.ReplacePlainString(DicomTag(0x0008, 0x0120), "UR");
654 dicom.ReplacePlainString(DicomTag(0x0008, 0x0301), "17"); // US
655 dicom.ReplacePlainString(DicomTag(0x0040, 0x0031), "UT");
656
657 DicomWebJsonVisitor visitor;
658 dicom.Apply(visitor);
659
660 std::string s;
661
662 // The tag (0002,0002) is "Media Storage SOP Class UID" and is
663 // automatically copied by DCMTK from tag (0008,0016)
664 ASSERT_EQ("UI", visitor.GetResult() ["00020002"]["vr"].asString());
665 ASSERT_EQ("UI", visitor.GetResult() ["00020002"]["Value"][0].asString());
666 ASSERT_EQ("AE", visitor.GetResult() ["00400241"]["vr"].asString());
667 ASSERT_EQ("AE", visitor.GetResult() ["00400241"]["Value"][0].asString());
668 ASSERT_EQ("AS", visitor.GetResult() ["00101010"]["vr"].asString());
669 ASSERT_EQ("AS", visitor.GetResult() ["00101010"]["Value"][0].asString());
670 ASSERT_EQ("AT", visitor.GetResult() ["00209165"]["vr"].asString());
671 ASSERT_EQ("00100020", visitor.GetResult() ["00209165"]["Value"][0].asString());
672 ASSERT_EQ("CS", visitor.GetResult() ["00080052"]["vr"].asString());
673 ASSERT_EQ("CS", visitor.GetResult() ["00080052"]["Value"][0].asString());
674 ASSERT_EQ("DA", visitor.GetResult() ["00080012"]["vr"].asString());
675 ASSERT_EQ("DA", visitor.GetResult() ["00080012"]["Value"][0].asString());
676 ASSERT_EQ("DS", visitor.GetResult() ["00101020"]["vr"].asString());
677 ASSERT_FLOAT_EQ(42.0f, visitor.GetResult() ["00101020"]["Value"][0].asFloat());
678 ASSERT_EQ("DT", visitor.GetResult() ["0008002A"]["vr"].asString());
679 ASSERT_EQ("DT", visitor.GetResult() ["0008002A"]["Value"][0].asString());
680 ASSERT_EQ("FL", visitor.GetResult() ["00109431"]["vr"].asString());
681 ASSERT_FLOAT_EQ(43.0f, visitor.GetResult() ["00109431"]["Value"][0].asFloat());
682 ASSERT_EQ("FD", visitor.GetResult() ["00081163"]["vr"].asString());
683 ASSERT_FLOAT_EQ(44.0f, visitor.GetResult() ["00081163"]["Value"][0].asFloat());
684 ASSERT_EQ("IS", visitor.GetResult() ["00081160"]["vr"].asString());
685 ASSERT_FLOAT_EQ(45.0f, visitor.GetResult() ["00081160"]["Value"][0].asFloat());
686 ASSERT_EQ("LO", visitor.GetResult() ["00080070"]["vr"].asString());
687 ASSERT_EQ("LO", visitor.GetResult() ["00080070"]["Value"][0].asString());
688 ASSERT_EQ("LT", visitor.GetResult() ["00104000"]["vr"].asString());
689 ASSERT_EQ("LT", visitor.GetResult() ["00104000"]["Value"][0].asString());
690
691 ASSERT_EQ("OB", visitor.GetResult() ["00282000"]["vr"].asString());
692 Toolbox::DecodeBase64(s, visitor.GetResult() ["00282000"]["InlineBinary"].asString());
693 ASSERT_EQ("OB", s);
694
695 #if DCMTK_VERSION_NUMBER >= 361
696 ASSERT_EQ("OD", visitor.GetResult() ["7FE00009"]["vr"].asString());
697 ASSERT_FLOAT_EQ(3.14159f, boost::lexical_cast<float>(visitor.GetResult() ["7FE00009"]["Value"][0].asString()));
698 #else
699 ASSERT_EQ("UN", visitor.GetResult() ["7FE00009"]["vr"].asString());
700 Toolbox::DecodeBase64(s, visitor.GetResult() ["7FE00009"]["InlineBinary"].asString());
701 ASSERT_EQ(8u, s.size()); // Because of padding
702 ASSERT_EQ(0, s[7]);
703 ASSERT_EQ("3.14159", s.substr(0, 7));
704 #endif
705
706 ASSERT_EQ("OF", visitor.GetResult() ["00640009"]["vr"].asString());
707 ASSERT_FLOAT_EQ(2.71828f, boost::lexical_cast<float>(visitor.GetResult() ["00640009"]["Value"][0].asString()));
708
709 #if DCMTK_VERSION_NUMBER < 361
710 ASSERT_EQ("UN", visitor.GetResult() ["00660040"]["vr"].asString());
711 Toolbox::DecodeBase64(s, visitor.GetResult() ["00660040"]["InlineBinary"].asString());
712 ASSERT_EQ("46", s);
713 #elif DCMTK_VERSION_NUMBER == 361
714 ASSERT_EQ("UL", visitor.GetResult() ["00660040"]["vr"].asString());
715 ASSERT_EQ(46, visitor.GetResult() ["00660040"]["Value"][0].asInt());
716 #else
717 ASSERT_EQ("OL", visitor.GetResult() ["00660040"]["vr"].asString());
718 ASSERT_EQ(46, visitor.GetResult() ["00660040"]["Value"][0].asInt());
719 #endif
720
721 ASSERT_EQ("OW", visitor.GetResult() ["00281201"]["vr"].asString());
722 Toolbox::DecodeBase64(s, visitor.GetResult() ["00281201"]["InlineBinary"].asString());
723 ASSERT_EQ("OWOW", s);
724
725 ASSERT_EQ("PN", visitor.GetResult() ["00100010"]["vr"].asString());
726 ASSERT_EQ("PN", visitor.GetResult() ["00100010"]["Value"][0]["Alphabetic"].asString());
727
728 ASSERT_EQ("SH", visitor.GetResult() ["00080050"]["vr"].asString());
729 ASSERT_EQ("SH", visitor.GetResult() ["00080050"]["Value"][0].asString());
730
731 ASSERT_EQ("SL", visitor.GetResult() ["00186020"]["vr"].asString());
732 ASSERT_EQ(-15, visitor.GetResult() ["00186020"]["Value"][0].asInt());
733
734 ASSERT_EQ("SS", visitor.GetResult() ["00189219"]["vr"].asString());
735 ASSERT_EQ(-16, visitor.GetResult() ["00189219"]["Value"][0].asInt());
736
737 ASSERT_EQ("ST", visitor.GetResult() ["00080081"]["vr"].asString());
738 ASSERT_EQ("ST", visitor.GetResult() ["00080081"]["Value"][0].asString());
739
740 ASSERT_EQ("TM", visitor.GetResult() ["00080013"]["vr"].asString());
741 ASSERT_EQ("TM", visitor.GetResult() ["00080013"]["Value"][0].asString());
742
743 #if DCMTK_VERSION_NUMBER >= 361
744 ASSERT_EQ("UC", visitor.GetResult() ["00080119"]["vr"].asString());
745 ASSERT_EQ("UC", visitor.GetResult() ["00080119"]["Value"][0].asString());
746 #else
747 ASSERT_EQ("UN", visitor.GetResult() ["00080119"]["vr"].asString());
748 Toolbox::DecodeBase64(s, visitor.GetResult() ["00080119"]["InlineBinary"].asString());
749 ASSERT_EQ("UC", s);
750 #endif
751
752 ASSERT_EQ("UI", visitor.GetResult() ["00080016"]["vr"].asString());
753 ASSERT_EQ("UI", visitor.GetResult() ["00080016"]["Value"][0].asString());
754
755 ASSERT_EQ("UL", visitor.GetResult() ["00081161"]["vr"].asString());
756 ASSERT_EQ(128u, visitor.GetResult() ["00081161"]["Value"][0].asUInt());
757
758 ASSERT_EQ("UN", visitor.GetResult() ["43421234"]["vr"].asString());
759 Toolbox::DecodeBase64(s, visitor.GetResult() ["43421234"]["InlineBinary"].asString());
760 ASSERT_EQ("UN", s);
761
762 #if DCMTK_VERSION_NUMBER >= 361
763 ASSERT_EQ("UR", visitor.GetResult() ["00080120"]["vr"].asString());
764 ASSERT_EQ("UR", visitor.GetResult() ["00080120"]["Value"][0].asString());
765 #else
766 ASSERT_EQ("UN", visitor.GetResult() ["00080120"]["vr"].asString());
767 Toolbox::DecodeBase64(s, visitor.GetResult() ["00080120"]["InlineBinary"].asString());
768 ASSERT_EQ("UR", s);
769 #endif
770
771 #if DCMTK_VERSION_NUMBER >= 361
772 ASSERT_EQ("US", visitor.GetResult() ["00080301"]["vr"].asString());
773 ASSERT_EQ(17u, visitor.GetResult() ["00080301"]["Value"][0].asUInt());
774 #else
775 ASSERT_EQ("UN", visitor.GetResult() ["00080301"]["vr"].asString());
776 Toolbox::DecodeBase64(s, visitor.GetResult() ["00080301"]["InlineBinary"].asString());
777 ASSERT_EQ("17", s);
778 #endif
779
780 ASSERT_EQ("UT", visitor.GetResult() ["00400031"]["vr"].asString());
781 ASSERT_EQ("UT", visitor.GetResult() ["00400031"]["Value"][0].asString());
782
783 std::string xml;
784 visitor.FormatXml(xml);
785
786 {
787 DicomMap m;
788 m.FromDicomWeb(visitor.GetResult());
789 ASSERT_EQ(31u, m.GetSize());
790
791 std::string s;
792 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0002, 0x0002), false)); ASSERT_EQ("UI", s);
793 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0040, 0x0241), false)); ASSERT_EQ("AE", s);
794 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0010, 0x1010), false)); ASSERT_EQ("AS", s);
795 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0020, 0x9165), false)); ASSERT_EQ("00100020", s);
796 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0052), false)); ASSERT_EQ("CS", s);
797 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0012), false)); ASSERT_EQ("DA", s);
798 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0010, 0x1020), false)); ASSERT_EQ("42", s);
799 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x002a), false)); ASSERT_EQ("DT", s);
800 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0010, 0x9431), false)); ASSERT_EQ("43", s);
801 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x1163), false)); ASSERT_EQ("44", s);
802 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x1160), false)); ASSERT_EQ("45", s);
803 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0070), false)); ASSERT_EQ("LO", s);
804 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0010, 0x4000), false)); ASSERT_EQ("LT", s);
805 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0028, 0x2000), true)); ASSERT_EQ("OB", s);
806 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x7fe0, 0x0009), true));
807
808 #if DCMTK_VERSION_NUMBER >= 361
809 ASSERT_FLOAT_EQ(3.14159f, boost::lexical_cast<float>(s));
810 #else
811 ASSERT_EQ(8u, s.size()); // Because of padding
812 ASSERT_EQ(0, s[7]);
813 ASSERT_EQ("3.14159", s.substr(0, 7));
814 #endif
815
816 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0064, 0x0009), true));
817 ASSERT_FLOAT_EQ(2.71828f, boost::lexical_cast<float>(s));
818 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0028, 0x1201), true)); ASSERT_EQ("OWOW", s);
819 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0010, 0x0010), false)); ASSERT_EQ("PN", s);
820 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0050), false)); ASSERT_EQ("SH", s);
821 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0018, 0x6020), false)); ASSERT_EQ("-15", s);
822 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0018, 0x9219), false)); ASSERT_EQ("-16", s);
823 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0081), false)); ASSERT_EQ("ST", s);
824 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0013), false)); ASSERT_EQ("TM", s);
825 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0016), false)); ASSERT_EQ("UI", s);
826 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x1161), false)); ASSERT_EQ("128", s);
827 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x4342, 0x1234), true)); ASSERT_EQ("UN", s);
828 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0040, 0x0031), false)); ASSERT_EQ("UT", s);
829
830 #if DCMTK_VERSION_NUMBER >= 361
831 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0066, 0x0040), false)); ASSERT_EQ("46", s);
832 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0119), false)); ASSERT_EQ("UC", s);
833 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0120), false)); ASSERT_EQ("UR", s);
834 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0301), false)); ASSERT_EQ("17", s);
835 #else
836 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0066, 0x0040), true)); ASSERT_EQ("46", s); // OL
837 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0119), true)); ASSERT_EQ("UC", s);
838 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0120), true)); ASSERT_EQ("UR", s);
839 ASSERT_TRUE(m.LookupStringValue(s, DicomTag(0x0008, 0x0301), true)); ASSERT_EQ("17", s); // US (but tag unknown to DCMTK 3.6.0)
840 #endif
841
842 }
843 }
844
845
846 TEST(DicomWebJson, Sequence)
847 {
848 ParsedDicomFile dicom(false);
849
850 {
851 std::unique_ptr<DcmSequenceOfItems> sequence(new DcmSequenceOfItems(DCM_ReferencedSeriesSequence));
852
853 for (unsigned int i = 0; i < 3; i++)
854 {
855 std::unique_ptr<DcmItem> item(new DcmItem);
856 std::string s = "item" + boost::lexical_cast<std::string>(i);
857 item->putAndInsertString(DCM_ReferencedSOPInstanceUID, s.c_str(), OFFalse);
858 ASSERT_TRUE(sequence->insert(item.release(), false, false).good());
859 }
860
861 ASSERT_TRUE(dicom.GetDcmtkObject().getDataset()->insert(sequence.release(), false, false).good());
862 }
863
864 DicomWebJsonVisitor visitor;
865 dicom.Apply(visitor);
866
867 ASSERT_EQ("SQ", visitor.GetResult() ["00081115"]["vr"].asString());
868 ASSERT_EQ(3u, visitor.GetResult() ["00081115"]["Value"].size());
869
870 std::set<std::string> items;
871
872 for (Json::Value::ArrayIndex i = 0; i < 3; i++)
873 {
874 ASSERT_EQ(1u, visitor.GetResult() ["00081115"]["Value"][i].size());
875 ASSERT_EQ(1u, visitor.GetResult() ["00081115"]["Value"][i]["00081155"]["Value"].size());
876 ASSERT_EQ("UI", visitor.GetResult() ["00081115"]["Value"][i]["00081155"]["vr"].asString());
877 items.insert(visitor.GetResult() ["00081115"]["Value"][i]["00081155"]["Value"][0].asString());
878 }
879
880 ASSERT_EQ(3u, items.size());
881 ASSERT_TRUE(items.find("item0") != items.end());
882 ASSERT_TRUE(items.find("item1") != items.end());
883 ASSERT_TRUE(items.find("item2") != items.end());
884
885 std::string xml;
886 visitor.FormatXml(xml);
887
888 {
889 DicomMap m;
890 m.FromDicomWeb(visitor.GetResult());
891 ASSERT_EQ(0u, m.GetSize()); // Sequences are not handled by DicomMap
892 }
893 }
894
895
896 TEST(DicomWebJson, PixelSpacing)
897 {
898 // Test related to locales: Make sure that decimal separator is
899 // correctly handled (dot "." vs comma ",")
900 ParsedDicomFile source(false);
901 source.ReplacePlainString(DICOM_TAG_PIXEL_SPACING, "1.5\\1.3");
902
903 DicomWebJsonVisitor visitor;
904 source.Apply(visitor);
905
906 DicomMap target;
907 target.FromDicomWeb(visitor.GetResult());
908
909 ASSERT_EQ("DS", visitor.GetResult() ["00280030"]["vr"].asString());
910 ASSERT_FLOAT_EQ(1.5f, visitor.GetResult() ["00280030"]["Value"][0].asFloat());
911 ASSERT_FLOAT_EQ(1.3f, visitor.GetResult() ["00280030"]["Value"][1].asFloat());
912
913 std::string s;
914 ASSERT_TRUE(target.LookupStringValue(s, DICOM_TAG_PIXEL_SPACING, false));
915 ASSERT_EQ(s, "1.5\\1.3");
916 }
917
918
919 TEST(DicomMap, MainTagNames)
920 {
921 ASSERT_EQ(3, ResourceType_Instance - ResourceType_Patient);
922
923 for (int i = ResourceType_Patient; i <= ResourceType_Instance; i++)
924 {
925 ResourceType level = static_cast<ResourceType>(i);
926
927 std::set<DicomTag> tags;
928 DicomMap::GetMainDicomTags(tags, level);
929
930 for (std::set<DicomTag>::const_iterator it = tags.begin(); it != tags.end(); ++it)
931 {
932 DicomMap a;
933 a.SetValue(*it, "TEST", false);
934
935 Json::Value json;
936 a.DumpMainDicomTags(json, level);
937
938 ASSERT_EQ(Json::objectValue, json.type());
939 ASSERT_EQ(1u, json.getMemberNames().size());
940
941 std::string name = json.getMemberNames() [0];
942 EXPECT_EQ(name, FromDcmtkBridge::GetTagName(*it, ""));
943
944 DicomMap b;
945 b.ParseMainDicomTags(json, level);
946
947 ASSERT_EQ(1u, b.GetSize());
948 ASSERT_EQ("TEST", b.GetStringValue(*it, "", false));
949
950 std::string main = it->GetMainTagsName();
951 if (!main.empty())
952 {
953 ASSERT_EQ(main, name);
954 }
955 }
956 }
957 }