Mercurial > hg > orthanc
annotate Core/MultiThreading/RunnableWorkersPool.cpp @ 3842:bdbe12aba99f
reducing the default number of threads in the HTTP server from 50 to 10
| author | Sebastien Jodogne <s.jodogne@gmail.com> |
|---|---|
| date | Thu, 16 Apr 2020 17:03:34 +0200 |
| parents | 2a170a8f1faf |
| children |
| rev | line source |
|---|---|
| 1679 | 1 /** |
| 2 * Orthanc - A Lightweight, RESTful DICOM Store | |
| 1900 | 3 * Copyright (C) 2012-2016 Sebastien Jodogne, Medical Physics |
| 1679 | 4 * Department, University Hospital of Liege, Belgium |
|
3640
94f4a18a79cc
upgrade to year 2020
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
3060
diff
changeset
|
5 * Copyright (C) 2017-2020 Osimis S.A., Belgium |
| 1679 | 6 * |
| 7 * This program is free software: you can redistribute it and/or | |
| 8 * modify it under the terms of the GNU General Public License as | |
| 9 * published by the Free Software Foundation, either version 3 of the | |
| 10 * License, or (at your option) any later version. | |
| 11 * | |
| 12 * In addition, as a special exception, the copyright holders of this | |
| 13 * program give permission to link the code of its release with the | |
| 14 * OpenSSL project's "OpenSSL" library (or with modified versions of it | |
| 15 * that use the same license as the "OpenSSL" library), and distribute | |
| 16 * the linked executables. You must obey the GNU General Public License | |
| 17 * in all respects for all of the code used other than "OpenSSL". If you | |
| 18 * modify file(s) with this exception, you may extend this exception to | |
| 19 * your version of the file(s), but you are not obligated to do so. If | |
| 20 * you do not wish to do so, delete this exception statement from your | |
| 21 * version. If you delete this exception statement from all source files | |
| 22 * in the program, then also delete it here. | |
| 23 * | |
| 24 * This program is distributed in the hope that it will be useful, but | |
| 25 * WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 26 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
| 27 * General Public License for more details. | |
| 28 * | |
| 29 * You should have received a copy of the GNU General Public License | |
| 30 * along with this program. If not, see <http://www.gnu.org/licenses/>. | |
| 31 **/ | |
| 32 | |
| 33 | |
| 34 #include "../PrecompiledHeaders.h" | |
| 35 #include "RunnableWorkersPool.h" | |
| 36 | |
| 37 #include "SharedMessageQueue.h" | |
|
3712
2a170a8f1faf
replacing std::auto_ptr by std::unique_ptr
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
3640
diff
changeset
|
38 #include "../Compatibility.h" |
| 1679 | 39 #include "../OrthancException.h" |
| 40 #include "../Logging.h" | |
| 41 | |
| 42 namespace Orthanc | |
| 43 { | |
| 44 struct RunnableWorkersPool::PImpl | |
| 45 { | |
| 46 class Worker | |
| 47 { | |
| 48 private: | |
| 49 const bool& continue_; | |
| 50 SharedMessageQueue& queue_; | |
| 51 boost::thread thread_; | |
| 52 | |
| 53 static void WorkerThread(Worker* that) | |
| 54 { | |
| 55 while (that->continue_) | |
| 56 { | |
|
2134
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
57 try |
| 1679 | 58 { |
|
3712
2a170a8f1faf
replacing std::auto_ptr by std::unique_ptr
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
3640
diff
changeset
|
59 std::unique_ptr<IDynamicObject> obj(that->queue_.Dequeue(100)); |
|
2134
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
60 if (obj.get() != NULL) |
| 1679 | 61 { |
| 62 IRunnableBySteps& runnable = *dynamic_cast<IRunnableBySteps*>(obj.get()); | |
|
2134
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
63 |
| 1679 | 64 bool wishToContinue = runnable.Step(); |
|
2134
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
65 |
| 1679 | 66 if (wishToContinue) |
| 67 { | |
| 68 // The runnable wishes to continue, reinsert it at the beginning of the queue | |
| 69 that->queue_.Enqueue(obj.release()); | |
| 70 } | |
| 71 } | |
|
2134
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
72 } |
|
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
73 catch (OrthancException& e) |
|
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
74 { |
|
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
75 LOG(ERROR) << "Exception while handling some runnable object: " << e.What(); |
|
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
76 } |
|
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
77 catch (std::bad_alloc&) |
|
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
78 { |
|
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
79 LOG(ERROR) << "Not enough memory to handle some runnable object"; |
|
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
80 } |
|
2290
4d500a555aad
catching std::exception before (...) to try to get more debug info
Alain Mazy <alain@mazy.be>
parents:
2244
diff
changeset
|
81 catch (std::exception& e) |
|
4d500a555aad
catching std::exception before (...) to try to get more debug info
Alain Mazy <alain@mazy.be>
parents:
2244
diff
changeset
|
82 { |
| 2291 | 83 LOG(ERROR) << "std::exception while handling some runnable object: " << e.what(); |
|
2290
4d500a555aad
catching std::exception before (...) to try to get more debug info
Alain Mazy <alain@mazy.be>
parents:
2244
diff
changeset
|
84 } |
|
2134
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
85 catch (...) |
|
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
86 { |
|
ddc75c6c712d
Avoid hard crash if not enough memory
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1900
diff
changeset
|
87 LOG(ERROR) << "Native exception while handling some runnable object"; |
| 1679 | 88 } |
| 89 } | |
| 90 } | |
| 91 | |
| 92 public: | |
| 93 Worker(const bool& globalContinue, | |
| 94 SharedMessageQueue& queue) : | |
| 95 continue_(globalContinue), | |
| 96 queue_(queue) | |
| 97 { | |
| 98 thread_ = boost::thread(WorkerThread, this); | |
| 99 } | |
| 100 | |
| 101 void Join() | |
| 102 { | |
| 103 if (thread_.joinable()) | |
| 104 { | |
| 105 thread_.join(); | |
| 106 } | |
| 107 } | |
| 108 }; | |
| 109 | |
| 110 | |
| 111 bool continue_; | |
| 112 std::vector<Worker*> workers_; | |
| 113 SharedMessageQueue queue_; | |
| 114 }; | |
| 115 | |
| 116 | |
| 117 | |
| 118 RunnableWorkersPool::RunnableWorkersPool(size_t countWorkers) : pimpl_(new PImpl) | |
| 119 { | |
| 120 pimpl_->continue_ = true; | |
| 121 | |
| 1847 | 122 if (countWorkers == 0) |
| 1679 | 123 { |
| 124 throw OrthancException(ErrorCode_ParameterOutOfRange); | |
| 125 } | |
| 126 | |
| 127 pimpl_->workers_.resize(countWorkers); | |
| 128 | |
| 129 for (size_t i = 0; i < countWorkers; i++) | |
| 130 { | |
| 131 pimpl_->workers_[i] = new PImpl::Worker(pimpl_->continue_, pimpl_->queue_); | |
| 132 } | |
| 133 } | |
| 134 | |
| 135 | |
|
1681
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
136 void RunnableWorkersPool::Stop() |
| 1679 | 137 { |
|
1681
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
138 if (pimpl_->continue_) |
| 1679 | 139 { |
|
1681
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
140 pimpl_->continue_ = false; |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
141 |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
142 for (size_t i = 0; i < pimpl_->workers_.size(); i++) |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
143 { |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
144 PImpl::Worker* worker = pimpl_->workers_[i]; |
| 1679 | 145 |
|
1681
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
146 if (worker != NULL) |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
147 { |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
148 worker->Join(); |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
149 delete worker; |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
150 } |
| 1679 | 151 } |
| 152 } | |
| 153 } | |
| 154 | |
| 155 | |
|
1681
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
156 RunnableWorkersPool::~RunnableWorkersPool() |
| 1679 | 157 { |
|
1681
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
158 Stop(); |
| 1679 | 159 } |
| 160 | |
| 161 | |
|
1681
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
162 void RunnableWorkersPool::Add(IRunnableBySteps* runnable) |
| 1679 | 163 { |
|
1681
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
164 if (!pimpl_->continue_) |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
165 { |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
166 throw OrthancException(ErrorCode_BadSequenceOfCalls); |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
167 } |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
168 |
|
ee4367497d0d
got rid of buggy BagOfRunnablesBySteps
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
1679
diff
changeset
|
169 pimpl_->queue_.Enqueue(runnable); |
| 1679 | 170 } |
| 171 } |