annotate .travis.yml @ 2248:69b0f4e8a49b

Escape multipart type parameter value in Content-Type header ## Summary Multipart responses do not quote/escape the value of their type parameter (the subtype) even though it always contains at least one special character (the slash "/"), which confuses standard-compliant HTTP clients. ## Details The Content-Type header in HTTP is in RFC 7231, Section 3.1.1.5: https://tools.ietf.org/html/rfc7231#section-3.1.1.5 The section defers to the media type section (3.1.1.1) for the syntax of the media type: https://tools.ietf.org/html/rfc7231#section-3.1.1.1 This states that a parameter value can be quoted: parameter = token "=" ( token / quoted-string ) A parameter value that matches the token production can be transmitted either as a token or within a quoted-string. The quoted and unquoted values are equivalent. Tokens are defined in RFC 7230, Section 3.2.6 (via RFC 7231, appendix C): https://tools.ietf.org/html/rfc7231#appendix-C https://tools.ietf.org/html/rfc7230#section-3.2.6 Here we observe that tokens cannot contain a slash "/" character: token = 1*tchar tchar = "!" / "#" / "$" / "%" / "&" / "'" / "*" / "+" / "-" / "." / "^" / "_" / "`" / "|" / "~" / DIGIT / ALPHA ; any VCHAR, except delimiters Delimiters are chosen from the set of US-ASCII visual characters not allowed in a token (DQUOTE and "(),/:;<=>?@[\]{}"). However, the current implementation does not quote/escape the value of the type parameter: multipart/related; type=application/dicom Instead, it should be: multipart/related; type="application/dicom" All of this also seems to apply to the MIME Content-Type header definition, even though it is a little different: https://www.iana.org/assignments/message-headers https://tools.ietf.org/html/rfc2045#section-5.1 https://tools.ietf.org/html/rfc2387
author Thibault Nélis <tn@osimis.io>
date Mon, 16 Jan 2017 13:07:11 +0100
parents d3e1548ca08e
children 1abfe0959c27
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1254
19b908908ebf travis setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
1 language: cpp
19b908908ebf travis setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
2
1264
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
3 env:
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
4 - TRAVIS_MINGW=OFF
1269
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
5 - TRAVIS_MINGW=ON
1264
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
6
1254
19b908908ebf travis setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
7 compiler:
1261
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
8 - gcc
1269
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
9 - clang
1258
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1257
diff changeset
10
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1257
diff changeset
11 os:
1269
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
12 - osx
1261
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
13 - linux
1258
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1257
diff changeset
14
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1257
diff changeset
15 osx_image: xcode61
1254
19b908908ebf travis setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
16
1261
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
17 matrix:
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
18 exclude:
1264
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
19 # This excludes OSX builds from the build matrix for gcc
1262
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1261
diff changeset
20 - os: osx
1261
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
21 compiler: gcc
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
22
1264
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
23 # Do not compile for OS X or clang when MinGW is enabled
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
24 - os: osx
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
25 env: TRAVIS_MINGW=ON
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
26 - compiler: clang
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
27 env: TRAVIS_MINGW=ON
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
28
1255
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1254
diff changeset
29 before_install:
1261
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
30 - if [ $TRAVIS_OS_NAME == linux ]; then sudo apt-get update -qq && sudo apt-get install
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
31 -qq build-essential unzip cmake mercurial uuid-dev libcurl4-openssl-dev liblua5.1-0-dev
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
32 libgtest-dev libpng-dev libsqlite3-dev libssl-dev zlib1g-dev libdcmtk2-dev libwrap0-dev
1264
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
33 libcharls-dev; fi
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
34 - if [ $TRAVIS_OS_NAME == linux -a $TRAVIS_MINGW == ON ]; then sudo apt-get install mingw32; fi
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
35
1258
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1257
diff changeset
36
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1257
diff changeset
37 before_script:
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1257
diff changeset
38 - mkdir Build
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1257
diff changeset
39 - cd Build
1265
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1264
diff changeset
40 - if [ $TRAVIS_OS_NAME == linux -a $TRAVIS_MINGW == OFF ]; then cmake
1264
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
41 -DCMAKE_BUILD_TYPE=Debug "-DDCMTK_LIBRARIES=CharLS;dcmjpls;wrap;oflog"
1261
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
42 -DALLOW_DOWNLOADS=ON -DUSE_SYSTEM_BOOST=OFF -DUSE_SYSTEM_MONGOOSE=OFF -DUSE_SYSTEM_JSONCPP=OFF
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
43 -DUSE_SYSTEM_GOOGLE_LOG=OFF -DUSE_SYSTEM_PUGIXML=OFF -DUSE_GTEST_DEBIAN_SOURCE_PACKAGE=ON
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
44 ..; fi
1265
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1264
diff changeset
45 - if [ $TRAVIS_OS_NAME == linux -a $TRAVIS_MINGW == ON ]; then cmake
1264
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
46 -DCMAKE_BUILD_TYPE=Debug -DSTATIC_BUILD=ON -DSTANDALONE_BUILD=ON -DALLOW_DOWNLOADS=ON
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
47 -DCMAKE_TOOLCHAIN_FILE=Resources/MinGWToolchain.cmake
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
48 ..; fi
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
49 - if [ $TRAVIS_OS_NAME == osx ]; then cmake
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
50 -DCMAKE_BUILD_TYPE=Debug -DSTATIC_BUILD=ON -DSTANDALONE_BUILD=ON -DALLOW_DOWNLOADS=ON
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1263
diff changeset
51 ..; fi
1261
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1260
diff changeset
52
1269
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
53 script: make && if [ $TRAVIS_MINGW == OFF ]; then ./UnitTests; fi
1254
19b908908ebf travis setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
diff changeset
54
1269
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
55 #script: cp ../README Orthanc
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
56 #deploy:
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
57 # provider: releases
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
58 # api_key:
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
59 # secure: WU+niKLAKMoJHST5EK23BayK4qXSrXELKlJYc8wRjMO4ay1KSgvzlY2UGKeW1EPClBfZZ0Uh5VKF8l34exsfirFuwCX2qceozduZproUszZ4Z88X8wt8Ctu8tBuuKLZYFc9iNH4zw+QZyRuPyXK9iWpS0L9O20pqy5upTsagM3o=
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
60 # file_glob: true
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
61 # file:
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
62 # - 'Build/Orthanc'
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
63 # - 'Build/UnitTests'
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
64 # - 'BuildMinGW32/Orthanc.exe'
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
65 # - 'BuildMinGW32/UnitTests.exe'
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
66 # skip_cleanup: true
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
67 # on:
d3e1548ca08e remove deploy
Sebastien Jodogne <s.jodogne@gmail.com>
parents: 1268
diff changeset
68 # all_branches: true