changeset 319:de6e73e4df60 Orthanc-1.7.2

leaving bitbucket
author Sebastien Jodogne <s.jodogne@gmail.com>
date Tue, 30 Jun 2020 16:14:30 +0200
parents bac7cc80f240
children 1f81f1d7d746
files GenerateConfigurationForTests.py Plugins/DicomWeb/Run.py Tests/Tests.py
diffstat 3 files changed, 27 insertions(+), 26 deletions(-) [+]
line wrap: on
line diff
--- a/GenerateConfigurationForTests.py	Mon Jun 22 16:15:31 2020 +0200
+++ b/GenerateConfigurationForTests.py	Tue Jun 30 16:14:30 2020 +0200
@@ -81,7 +81,8 @@
 
 # Download the content of the default configuration file
 with open(args.target, 'w') as f:
-    url = 'https://hg.orthanc-server.com/orthanc/raw-file/default/Resources/Configuration.json'
+    url = 'https://hg.orthanc-server.com/orthanc/raw-file/default/OrthancServer/Resources/Configuration.json'
+    #url = 'https://hg.orthanc-server.com/orthanc/raw-file/default/Resources/Configuration.json'
     #url = 'https://bitbucket.org/sjodogne/orthanc/raw/default/Resources/Configuration.json'
     http = urllib.urlopen(url)
     if http.getcode() != 200:
--- a/Plugins/DicomWeb/Run.py	Mon Jun 22 16:15:31 2020 +0200
+++ b/Plugins/DicomWeb/Run.py	Tue Jun 30 16:14:30 2020 +0200
@@ -360,7 +360,7 @@
         
     def test_bitbucket_issue_53(self):
         # DICOMWeb plugin support for "limit" and "offset" parameters in QIDO-RS
-        # https://bitbucket.org/sjodogne/orthanc/issues/53
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=53
         
         UploadInstance(ORTHANC, 'Brainix/Flair/IM-0001-0001.dcm')
         UploadInstance(ORTHANC, 'Knee/T1/IM-0001-0001.dcm')
@@ -389,8 +389,8 @@
 
     def test_bitbucket_issue_111(self):
         # Wrong serialization of empty values
-        # https://bitbucket.org/sjodogne/orthanc/issues/111
-        # https://bitbucket.org/sjodogne/orthanc-dicomweb/issues/3/
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=111
+        # https://bitbucket.org/sjodogne/orthanc-dicomweb/issues/3
 
         # According to the standard, section F.2.5
         # (http://dicom.nema.org/medical/dicom/current/output/chtml/part18/sect_F.2.5.html),
@@ -398,7 +398,7 @@
         # DICOM but empty (i.e., Value Length is 0), it shall be
         # preserved in the DICOM JSON attribute object containing no
         # "Value", "BulkDataURI" or "InlineBinary".
-        # https://bitbucket.org/sjodogne/orthanc/issues/111/qido-rs-wrong-serialization-of-empty
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=111
 
         UploadInstance(ORTHANC, 'Issue111.dcm')
 
@@ -483,8 +483,8 @@
         sop = '1.2.840.113619.2.115.147416.1094281639.0.38'
 
         # WARNING: This test will fail on Orthanc <= 1.5.5, because
-        # the following fix is not included yet:
-        # https://bitbucket.org/sjodogne/orthanc/commits/b88937ef597b33c4387a546c751827019bcdc205
+        # the following fix was not included yet:
+        # https://hg.orthanc-server.com/orthanc/rev/b88937ef597b
         
         a = DoGet(ORTHANC, '/dicom-web/studies/%s/metadata' % study)
         self.assertEqual(1, len(a))
@@ -507,7 +507,7 @@
 
     def test_bitbucket_issue_112(self):
         # Wrong serialization of number values
-        # https://bitbucket.org/sjodogne/orthanc/issues/112
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=112
         # https://bitbucket.org/sjodogne/orthanc-dicomweb/issues/4/
         
         UploadInstance(ORTHANC, 'DummyCT.dcm')
@@ -539,7 +539,7 @@
 
     def test_bitbucket_issue_113(self):
         # Wrong serialization of PN VR
-        # https://bitbucket.org/sjodogne/orthanc/issues/113
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=113
         # https://bitbucket.org/sjodogne/orthanc-dicomweb/issues/2/
 
         # Make sure UTF-8 encoding is used
@@ -571,7 +571,7 @@
 
     def test_bitbucket_issue_96(self):
         # WADO-RS RetrieveFrames rejects valid accept headers
-        # https://bitbucket.org/sjodogne/orthanc/issues/96
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=96
         # https://bitbucket.org/sjodogne/orthanc-dicomweb/issues/5/
         
         UploadInstance(ORTHANC, 'Brainix/Epi/IM-0001-0001.dcm')
@@ -759,7 +759,7 @@
     def test_bitbucket_issue_143(self):
         # WADO-RS metadata request returns "500 Internal Server Error"
         # instead of "404 Not Found" for missing instance
-        # https://bitbucket.org/sjodogne/orthanc/issues/143
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=143
         UploadInstance(ORTHANC, 'Issue143.dcm')
 
         try:
@@ -1003,7 +1003,7 @@
     #@unittest.skip("Skip this test on GDCM 2.8.4")
     def test_bitbucket_issue_164(self):
         # WARNING - This makes GDCM 2.8.4 crash
-        # https://bitbucket.org/sjodogne/orthanc/issues/164
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=164
         UploadInstance(ORTHANC, 'Issue164.dcm')
 
         p = DoGetMultipart(ORTHANC, 'dicom-web/studies/1.2.276.0.26.1.1.1.2.2020.45.52293.1506048/series/1.2.276.0.26.1.1.1.2.2020.45.52293.6384450/instances/1.2.276.0.26.1.1.1.2.2020.45.52366.2551599.179568640/frames/5')
@@ -1023,7 +1023,7 @@
         # "Plugins can't read private tags from the configuration
         # file" This test will fail if DCMTK <= 3.6.1 (e.g. on Ubuntu
         # 16.04), or if Orthanc <= 1.5.8
-        # https://bitbucket.org/sjodogne/orthanc/issues/168/
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=168
 
         UploadInstance(ORTHANC, 'Issue168.dcm')
 
@@ -1131,7 +1131,7 @@
     def test_bitbucket_issue_56(self):
         # "Case-insensitive matching over accents" => DICOMweb part
         # from AlexanderM on 2020-03-20
-        # https://bitbucket.org/sjodogne/orthanc/issues/56/
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=56
         UploadInstance(ORTHANC, 'Issue56-NoPixelData.dcm')
 
         self.assertEqual(1, len(DoPost(ORTHANC, '/tools/find', {
--- a/Tests/Tests.py	Mon Jun 22 16:15:31 2020 +0200
+++ b/Tests/Tests.py	Tue Jun 30 16:14:30 2020 +0200
@@ -3421,7 +3421,7 @@
 
 
     def test_bitbucket_issue_44(self):
-        # https://bitbucket.org/sjodogne/orthanc/issues/44/bad-interpretation-of-photometric
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=44
         UploadInstance(_REMOTE, 'Issue44/Monochrome1.dcm')
         UploadInstance(_REMOTE, 'Issue44/Monochrome2.dcm')
 
@@ -3461,7 +3461,7 @@
 
 
     def test_bitbucket_issue_42(self):
-        # https://bitbucket.org/sjodogne/orthanc/issues/42/fails-to-modify-a-dicom-video-file
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=42
         # This test fails on DCMTK 3.6.0, but succeeds in DCMTK 3.6.1 snapshots and DCMTK 3.6.2
         UploadInstance(_REMOTE, 'Issue42.dcm')['ID']
         modified = DoPost(_REMOTE,
@@ -3473,7 +3473,7 @@
 
     def test_rest_find_limit(self):
         # Check the "Since" and "Limit" parameters in URI "/tools/find"
-        # Related to issue 53: https://bitbucket.org/sjodogne/orthanc/issues/53
+        # Related to issue 53: https://bugs.orthanc-server.com/show_bug.cgi?id=53
         
         # Upload 6 instances
         brainix = []
@@ -3542,7 +3542,7 @@
 
     def test_bitbucket_issue_46(self):
         # "PHI remaining after anonymization"
-        # https://bitbucket.org/sjodogne/orthanc/issues/46
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=46
 
         def GetAnonymizedTags(study, version):
             anonymized = DoPost(_REMOTE, '/studies/%s/anonymize' % study,
@@ -3631,7 +3631,7 @@
         # Case-insensitive matching over accents. This test assumes
         # that the "CaseSensitivePN" configuration option of Orthanc
         # is set to "false" (default value).
-        # https://bitbucket.org/sjodogne/orthanc/issues/56
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=56
 
         def Check(name, expected, expectedSensitive):
             a = CallFindScu([ '-k', '0008,0005=ISO_IR 192',  # Use UTF-8
@@ -3916,7 +3916,7 @@
 
     def test_bitbucket_issue_94(self):
         # "a simple instance modification should not modify FrameOfReferenceUID + ..."
-        # https://bitbucket.org/sjodogne/orthanc/issues/94
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=94
         i = UploadInstance(_REMOTE, 'Issue94.dcm')['ID']
 
         source = DoGet(_REMOTE, '/instances/%s/attachments/dicom/data' % i)
@@ -4501,7 +4501,7 @@
 
 
     def test_issue_95_encodings(self):
-        # https://bitbucket.org/sjodogne/orthanc/issues/95/server-cant-support-chinese
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=95
         # Check out image: "../Database/Encodings/DavidClunie/charsettests.screenshot.png"
 
         # Very useful tool: "file2" from package "file-kanji"
@@ -4580,7 +4580,7 @@
     def test_bitbucket_issue_131(self):
         # "Orthanc PACS silently fails to C-MOVE due to duplicate
         # StudyInstanceUID in it's database."
-        # https://bitbucket.org/sjodogne/orthanc/issues/131/orthanc-pacs-silently-fails-to-c-move-due
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=131
 
         # Insert 2 instances, with the same StudyInstanceUID, but with
         # different patient IDs. Orthanc will create 2 distincts
@@ -4793,7 +4793,7 @@
     def test_bitbucket_issue_140(self):
         # "Modifying private tags with REST API changes VR from LO to
         # UN." This test fails if DCMTK <= 3.6.1 (e.g. fails on Ubuntu 16.04).
-        # https://bitbucket.org/sjodogne/orthanc/issues/140
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=140
         source = UploadInstance(_REMOTE, 'Issue140.dcm') ['ID']
         series = DoGet(_REMOTE, '/instances/%s' % source) ['ParentSeries']
 
@@ -4874,7 +4874,7 @@
 
 
     def test_bitbucket_issue_141(self):
-        # https://bitbucket.org/sjodogne/orthanc/issues/141/
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=141
         a = UploadInstance(_REMOTE, 'Issue141.dcm') ['ID']
         study = '494c8037-b237f263-d8f15075-c8cb2280-daf39bd1'
 
@@ -4900,7 +4900,7 @@
 
 
     def test_log_level(self):
-        # https://bitbucket.org/sjodogne/orthanc/issues/65/
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=65
         original = DoGet(_REMOTE, '/tools/log-level')
         
         DoPut(_REMOTE, '/tools/log-level', 'default')
@@ -5270,7 +5270,7 @@
 
     def test_bitbucket_issue_154(self):
         # "Matching against list of UID-s by C-MOVE"
-        # https://bitbucket.org/sjodogne/orthanc/issues/154/
+        # https://bugs.orthanc-server.com/show_bug.cgi?id=154
         a = UploadInstance(_REMOTE, 'Issue154-d1.dcm') ['ID']
         b = UploadInstance(_REMOTE, 'Issue154-d2.dcm') ['ID']