Mercurial > hg > orthanc-stone

changeset 1290:7def6ab2929f bugs/2020-02-invisible-slice

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Removal of debugging logs
author Benjamin Golinvaux <bgo@osimis.io>
date Fri, 21 Feb 2020 15:20:29 +0100
parents 343aa1dfaa90
children ea6c2254536d
files Applications/Generic/GuiAdapter.cpp Applications/Generic/GuiAdapter.h Framework/Scene2D/FloatTextureSceneLayer.cpp Framework/Volumes/DicomVolumeImageMPRSlicer.cpp
diffstat 4 files changed, 0 insertions(+), 83 deletions(-) [+]
line wrap: on
line diff
--- a/Applications/Generic/GuiAdapter.cpp	Wed Feb 19 17:05:08 2020 +0100
+++ b/Applications/Generic/GuiAdapter.cpp	Fri Feb 21 15:20:29 2020 +0100
@@ -36,15 +36,6 @@
 
 namespace OrthancStone
 {
-#if 0
-  void GuiAdapter::RegisterWidget(boost::shared_ptr<IGuiAdapterWidget> widget)
-  {
-    LOG(INFO) << "GuiAdapter::RegisterWidget" 
-
-    widgets_.push_back(widget);
-  }
-#endif
-
   std::ostream& operator<<(
     std::ostream& os, const GuiAdapterKeyboardEvent& event)
   {
--- a/Applications/Generic/GuiAdapter.h	Wed Feb 19 17:05:08 2020 +0100
+++ b/Applications/Generic/GuiAdapter.h	Fri Feb 21 15:20:29 2020 +0100
@@ -235,11 +235,6 @@
       instanceCount = 1;
     }
 
-
-#if 0
-    void RegisterWidget(boost::shared_ptr<IGuiAdapterWidget> widget);
-#endif
-    
     /**
       emscripten_set_resize_callback("#window", NULL, false, OnWindowResize);
 
@@ -364,24 +359,5 @@
     deals with this)
     */
     void ViewportsUpdateSize();
-
-
-#if 0
-    std::vector<boost::weak_ptr<IGuiAdapterWidget> > widgets_;
-
-    template<typename F> void VisitWidgets(F func)
-    {
-      for (size_t i = 0; i < widgets_.size(); i++)
-      {
-        boost::shared_ptr<IGuiAdapterWidget> widget = widgets_[i].lock();
-
-        // TODO: we need to clean widgets!
-        if (widget.get() != NULL)
-        {
-          func(widget);
-        }
-      }
-    }
-#endif
   };
 }
--- a/Framework/Scene2D/FloatTextureSceneLayer.cpp	Wed Feb 19 17:05:08 2020 +0100
+++ b/Framework/Scene2D/FloatTextureSceneLayer.cpp	Fri Feb 21 15:20:29 2020 +0100
@@ -41,29 +41,6 @@
 
       Orthanc::ImageProcessing::Convert(*t, texture);
 
-      if (OrthancStone_Internals_dump_LoadTexture_histogram == 1)
-      {
-        LOG(INFO) << "+----------------------------------------+";
-        LOG(INFO) << "|        This is not an error!           |";
-        LOG(INFO) << "+----------------------------------------+";
-        LOG(INFO) << "Work on the \"invisible slice\" bug";
-        LOG(INFO) << "in FloatTextureSceneLayer::FloatTextureSceneLayer";
-        LOG(INFO) << "will dump \"t\" after \"Orthanc::ImageProcessing::Convert(*t, texture);\"";
-
-        HistogramData hd;
-        double minValue = 0;
-        double maxValue = 0;
-        ComputeMinMax(*t, minValue, maxValue);
-        double binSize = (maxValue - minValue) * 0.01;
-        ComputeHistogram(*t, hd, binSize);
-        std::string s;
-        DumpHistogramResult(s, hd);
-        LOG(INFO) << s;
-        LOG(INFO) << "+----------------------------------------+";
-        LOG(INFO) << "|        end of debug dump               |";
-        LOG(INFO) << "+----------------------------------------+";
-      }
-
       SetTexture(t.release());
     }
 
--- a/Framework/Volumes/DicomVolumeImageMPRSlicer.cpp	Wed Feb 19 17:05:08 2020 +0100
+++ b/Framework/Volumes/DicomVolumeImageMPRSlicer.cpp	Fri Feb 21 15:20:29 2020 +0100
@@ -85,33 +85,6 @@
       const DicomInstanceParameters& parameters = volume_.GetDicomParameters();
       ImageBuffer3D::SliceReader reader(volume_.GetPixelData(), projection_, sliceIndex_);
 
-      if (OrthancStone_Internals_dump_LoadTexture_histogram == 1)
-      {
-        LOG(INFO) << "+----------------------------------------+";
-        LOG(INFO) << "|        This is not an error!           |";
-        LOG(INFO) << "+----------------------------------------+";
-        LOG(INFO) << "Work on the \"invisible slice\" bug";
-        LOG(INFO) << "DicomVolumeImageMPRSlicer::Slice::CreateSceneLayer";
-        LOG(INFO) << "InvisibleSlice -- about to dump histogram (100 buckets) for volume_ "
-          << "with OrthancId: " << parameters.GetOrthancInstanceIdentifier()
-          << " and SopInstanceUid: " << parameters.GetSopInstanceUid()
-          << " for projection_ (AxiCorSag): projection_ "
-          << " and slice: " << sliceIndex_;
-
-        HistogramData hd;
-        double minValue = 0;
-        double maxValue = 0;
-        ComputeMinMax(reader.GetAccessor(), minValue, maxValue);
-        double binSize = (maxValue - minValue) * 0.01;
-        ComputeHistogram(reader.GetAccessor(), hd, binSize);
-        std::string s;
-        DumpHistogramResult(s, hd);
-        LOG(INFO) << s;
-        LOG(INFO) << "+----------------------------------------+";
-        LOG(INFO) << "|        end of debug dump               |";
-        LOG(INFO) << "+----------------------------------------+";
-      }
-
       texture.reset(dynamic_cast<TextureBaseSceneLayer*>
                     (configurator->CreateTextureFromDicom(reader.GetAccessor(), parameters)));