# HG changeset patch # User Benjamin Golinvaux # Date 1583324412 -3600 # Node ID 1f877e0846fe90e5b4c9f4049df9144237a7d3dd # Parent adf234ecaa0036ee000368ae2d8fb15ea1bc2473 Fixed some warnings + fixed build for C++03 diff -r adf234ecaa00 -r 1f877e0846fe Framework/Loaders/SeriesFramesLoader.cpp --- a/Framework/Loaders/SeriesFramesLoader.cpp Wed Mar 04 10:21:54 2020 +0100 +++ b/Framework/Loaders/SeriesFramesLoader.cpp Wed Mar 04 13:20:12 2020 +0100 @@ -226,7 +226,7 @@ float w = payload.GetWindowingWidth(); if (w <= 0.01f) { - w = 0.01; // Prevent division by zero + w = 0.01f; // Prevent division by zero } const float c = payload.GetWindowingCenter(); diff -r adf234ecaa00 -r 1f877e0846fe Framework/Radiography/RadiographyScene.cpp --- a/Framework/Radiography/RadiographyScene.cpp Wed Mar 04 10:21:54 2020 +0100 +++ b/Framework/Radiography/RadiographyScene.cpp Wed Mar 04 13:20:12 2020 +0100 @@ -715,7 +715,7 @@ // wipe background before rendering if (GetPreferredPhotomotricDisplayMode() == RadiographyPhotometricDisplayMode_Monochrome1) { - Orthanc::ImageProcessing::Set(layers, 65535.0f); + Orthanc::ImageProcessing::Set(layers, 65535); } else { diff -r adf234ecaa00 -r 1f877e0846fe Framework/Scene2DViewport/AngleMeasureTool.cpp --- a/Framework/Scene2DViewport/AngleMeasureTool.cpp Wed Mar 04 10:21:54 2020 +0100 +++ b/Framework/Scene2DViewport/AngleMeasureTool.cpp Wed Mar 04 13:20:12 2020 +0100 @@ -45,9 +45,9 @@ IViewport& viewport) : MeasureTool(viewport) #if ORTHANC_STONE_ENABLE_OUTLINED_TEXT == 1 - , layerHolder_(boost::make_shared(viewport,1,5)) + , layerHolder_(boost::shared_ptr(new LayerHolder(viewport,1,5))) #else - , layerHolder_(boost::make_shared(viewport, 1, 1)) + , layerHolder_(boost::shared_ptr(new LayerHolder(viewport,1,1))) #endif , angleHighlightArea_(AngleHighlightArea_None) { diff -r adf234ecaa00 -r 1f877e0846fe Framework/Scene2DViewport/CreateAngleMeasureCommand.cpp --- a/Framework/Scene2DViewport/CreateAngleMeasureCommand.cpp Wed Mar 04 10:21:54 2020 +0100 +++ b/Framework/Scene2DViewport/CreateAngleMeasureCommand.cpp Wed Mar 04 13:20:12 2020 +0100 @@ -30,7 +30,7 @@ ScenePoint2D point) : CreateMeasureCommand(viewport) , measureTool_( - boost::make_shared(viewport)) + boost::shared_ptr(new AngleMeasureTool(viewport))) { std::unique_ptr lock(viewport_.Lock()); diff -r adf234ecaa00 -r 1f877e0846fe Framework/Scene2DViewport/CreateLineMeasureCommand.cpp --- a/Framework/Scene2DViewport/CreateLineMeasureCommand.cpp Wed Mar 04 10:21:54 2020 +0100 +++ b/Framework/Scene2DViewport/CreateLineMeasureCommand.cpp Wed Mar 04 13:20:12 2020 +0100 @@ -30,7 +30,7 @@ ScenePoint2D point) : CreateMeasureCommand(viewport) , measureTool_( - boost::make_shared(viewport)) + boost::shared_ptr(new LineMeasureTool(viewport))) { std::unique_ptr lock(viewport_.Lock()); diff -r adf234ecaa00 -r 1f877e0846fe Framework/Scene2DViewport/LineMeasureTool.cpp --- a/Framework/Scene2DViewport/LineMeasureTool.cpp Wed Mar 04 10:21:54 2020 +0100 +++ b/Framework/Scene2DViewport/LineMeasureTool.cpp Wed Mar 04 13:20:12 2020 +0100 @@ -35,9 +35,9 @@ IViewport& viewport) : MeasureTool(viewport) #if ORTHANC_STONE_ENABLE_OUTLINED_TEXT == 1 - , layerHolder_(boost::make_shared(viewport, 1, 5)) + , layerHolder_(boost::shared_ptr(new LayerHolder(viewport,1,5))) #else - , layerHolder_(boost::make_shared(viewport, 1, 1)) + , layerHolder_(boost::shared_ptr(new LayerHolder(viewport,1,1))) #endif , lineHighlightArea_(LineHighlightArea_None) { diff -r adf234ecaa00 -r 1f877e0846fe Framework/Scene2DViewport/ViewportController.cpp --- a/Framework/Scene2DViewport/ViewportController.cpp Wed Mar 04 10:21:54 2020 +0100 +++ b/Framework/Scene2DViewport/ViewportController.cpp Wed Mar 04 13:20:12 2020 +0100 @@ -66,7 +66,8 @@ ViewportController::ViewportController(IViewport& viewport) : viewport_(viewport) - , undoStackW_(boost::make_shared()) + , undoStackW_(boost::shared_ptr(new UndoStack())) + , scene_(new Scene2D) , canvasToSceneFactor_(1) { @@ -75,7 +76,7 @@ ViewportController::ViewportController(IViewport& viewport, const Scene2D& scene) : viewport_(viewport) - , undoStackW_(boost::make_shared()) + , undoStackW_(boost::shared_ptr(new UndoStack())) , scene_(scene.Clone()) , canvasToSceneFactor_(1) { diff -r adf234ecaa00 -r 1f877e0846fe UnitTestsSources/UnitTestsMain.cpp --- a/UnitTestsSources/UnitTestsMain.cpp Wed Mar 04 10:21:54 2020 +0100 +++ b/UnitTestsSources/UnitTestsMain.cpp Wed Mar 04 13:20:12 2020 +0100 @@ -807,21 +807,21 @@ ASSERT_TRUE(OrthancStone::LinearAlgebra::ParseVector(v, "1.2")); ASSERT_EQ(1u, v.size()); - ASSERT_FLOAT_EQ(1.2f, v[0]); + ASSERT_DOUBLE_EQ(1.2, v[0]); ASSERT_TRUE(OrthancStone::LinearAlgebra::ParseVector(v, "-1.2e+2")); ASSERT_EQ(1u, v.size()); - ASSERT_FLOAT_EQ(-120.0f, v[0]); + ASSERT_DOUBLE_EQ(-120.0, v[0]); ASSERT_TRUE(OrthancStone::LinearAlgebra::ParseVector(v, "-1e-2\\2")); ASSERT_EQ(2u, v.size()); - ASSERT_FLOAT_EQ(-0.01f, v[0]); - ASSERT_FLOAT_EQ(2.0f, v[1]); + ASSERT_DOUBLE_EQ(-0.01, v[0]); + ASSERT_DOUBLE_EQ(2.0, v[1]); ASSERT_TRUE(OrthancStone::LinearAlgebra::ParseVector(v, "1.3671875\\1.3671875")); ASSERT_EQ(2u, v.size()); - ASSERT_FLOAT_EQ(1.3671875, v[0]); - ASSERT_FLOAT_EQ(1.3671875, v[1]); + ASSERT_DOUBLE_EQ(1.3671875, v[0]); + ASSERT_DOUBLE_EQ(1.3671875, v[1]); }