diff OrthancStone/Sources/Loaders/DicomStructureSetLoader.cpp @ 1571:85e117739eca

cppcheck
author Sebastien Jodogne <s.jodogne@gmail.com>
date Mon, 21 Sep 2020 17:46:39 +0200
parents 244ad1e4e76a
children 4fb8fdf03314
line wrap: on
line diff
--- a/OrthancStone/Sources/Loaders/DicomStructureSetLoader.cpp	Mon Sep 21 14:50:26 2020 +0200
+++ b/OrthancStone/Sources/Loaders/DicomStructureSetLoader.cpp	Mon Sep 21 17:46:39 2020 +0200
@@ -62,9 +62,9 @@
     }
 
   protected:
-    RestInstanceLookupHandler(DicomStructureSetLoader& loader) 
-      : LoaderStateMachine(loader.loadersContext_)
-      , loader_(loader)
+    explicit RestInstanceLookupHandler(DicomStructureSetLoader& loader) :
+      LoaderStateMachine(loader.loadersContext_),
+      loader_(loader)
     {
     }
 
@@ -91,7 +91,7 @@
     {
     }
 
-    virtual void Handle(const OrthancStone::OrthancRestApiCommand::SuccessMessage& message)
+    virtual void Handle(const OrthancStone::OrthancRestApiCommand::SuccessMessage& message) ORTHANC_OVERRIDE
     {
       Json::Value tags;
       message.ParseJsonBody(tags);
@@ -120,7 +120,7 @@
     {
     }
 
-    virtual void Handle(const OrthancStone::OrthancRestApiCommand::SuccessMessage& message)
+    virtual void Handle(const OrthancStone::OrthancRestApiCommand::SuccessMessage& message) ORTHANC_OVERRIDE
     {
       DicomStructureSetLoader& loader = GetLoader<DicomStructureSetLoader>();
 
@@ -179,12 +179,12 @@
   class DicomStructureSetLoader::LoadStructure : public LoaderStateMachine::State
   {
   public:
-    LoadStructure(DicomStructureSetLoader& that) :
-    State(that)
+    explicit LoadStructure(DicomStructureSetLoader& that) :
+      State(that)
     {
     }
     
-    virtual void Handle(const OrthancStone::OrthancRestApiCommand::SuccessMessage& message)
+    virtual void Handle(const OrthancStone::OrthancRestApiCommand::SuccessMessage& message) ORTHANC_OVERRIDE
     {
       DicomStructureSetLoader& loader = GetLoader<DicomStructureSetLoader>();
 
@@ -291,10 +291,10 @@
     Slice(const OrthancStone::DicomStructureSet& content,
           uint64_t revision,
           const OrthancStone::CoordinateSystem3D& cuttingPlane,
-          std::vector<bool> visibility = std::vector<bool>()) 
-      : content_(content)
-      , revision_(revision)
-      , visibility_(visibility)
+          const std::vector<bool>& visibility) :
+      content_(content),
+      revision_(revision),
+      visibility_(visibility)
     {
       ORTHANC_ASSERT((visibility_.size() == content_.GetStructuresCount())
         || (visibility_.size() == 0u));
@@ -308,19 +308,19 @@
         OrthancStone::GeometryToolbox::IsParallelOrOpposite(opposite, normal, cuttingPlane.GetAxisY()));
     }
       
-    virtual bool IsValid()
+    virtual bool IsValid() ORTHANC_OVERRIDE
     {
       return isValid_;
     }
 
-    virtual uint64_t GetRevision()
+    virtual uint64_t GetRevision() ORTHANC_OVERRIDE
     {
       return revision_;
     }
 
     virtual OrthancStone::ISceneLayer* CreateSceneLayer(
       const OrthancStone::ILayerStyleConfigurator* configurator,
-      const OrthancStone::CoordinateSystem3D& cuttingPlane)
+      const OrthancStone::CoordinateSystem3D& cuttingPlane) ORTHANC_OVERRIDE
     {
       assert(isValid_);