diff Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp @ 1573:32e0c007789d

cppcheck
author Sebastien Jodogne <s.jodogne@gmail.com>
date Mon, 21 Sep 2020 18:28:34 +0200
parents b8b4cb58a874
children e4a52cbbdd70
line wrap: on
line diff
--- a/Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp	Mon Sep 21 18:13:52 2020 +0200
+++ b/Applications/StoneWebViewer/WebAssembly/StoneWebViewer.cpp	Mon Sep 21 18:28:34 2020 +0200
@@ -151,7 +151,7 @@
   boost::shared_ptr<OrthancStone::SeriesThumbnailsLoader>  thumbnailsLoader_;
   boost::shared_ptr<OrthancStone::SeriesMetadataLoader>    metadataLoader_;
 
-  ResourcesLoader(const OrthancStone::DicomSource& source) :
+  explicit ResourcesLoader(const OrthancStone::DicomSource& source) :
     source_(source),
     pending_(0),
     studies_(new OrthancStone::LoadedDicomResources(Orthanc::DICOM_TAG_STUDY_INSTANCE_UID)),
@@ -385,7 +385,7 @@
       assert(image != NULL);
     }
 
-    virtual size_t GetMemoryUsage() const
+    virtual size_t GetMemoryUsage() const ORTHANC_OVERRIDE
     {    
       assert(image_.get() != NULL);
       return (image_->GetBytesPerPixel() * image_->GetPitch() * image_->GetHeight());
@@ -705,7 +705,7 @@
   }
   
 public:
-  SeriesCursor(size_t framesCount) :
+  explicit SeriesCursor(size_t framesCount) :
     framesCount_(framesCount),
     currentFrame_(framesCount / 2),  // Start at the middle frame    
     isCircular_(false),
@@ -792,12 +792,14 @@
   OrthancStone::Extent2D            extent_;
 
 public:
-  FrameGeometry() :
-    isValid_(false)
+  explicit FrameGeometry() :
+    isValid_(false),
+    pixelSpacingX_(1),
+    pixelSpacingY_(1)
   {
   }
     
-  FrameGeometry(const Orthanc::DicomMap& tags) :
+  explicit FrameGeometry(const Orthanc::DicomMap& tags) :
     isValid_(false),
     coordinates_(tags)
   {
@@ -945,7 +947,7 @@
     boost::shared_ptr<ViewerViewport>  viewport_;
     
   public:
-    ICommand(boost::shared_ptr<ViewerViewport> viewport) :
+    explicit ICommand(boost::shared_ptr<ViewerViewport> viewport) :
       viewport_(viewport)
     {
       if (viewport == NULL)
@@ -983,7 +985,7 @@
   class SetDefaultWindowingCommand : public ICommand
   {
   public:
-    SetDefaultWindowingCommand(boost::shared_ptr<ViewerViewport> viewport) :
+    explicit SetDefaultWindowingCommand(boost::shared_ptr<ViewerViewport> viewport) :
       ICommand(viewport)
     {
     }