# HG changeset patch
# User Sebastien Jodogne <s.jodogne@gmail.com>
# Date 1734512906 -3600
# Node ID d79ba6cbf0eefbda193a29d72325cf251cc29590
# Parent  0aaeae85be085906c09dc329c5b9941f4b385f51
cppcheck

diff -r 0aaeae85be08 -r d79ba6cbf0ee Framework/Common/DatabaseManager.h
--- a/Framework/Common/DatabaseManager.h	Tue Dec 17 20:33:12 2024 +0100
+++ b/Framework/Common/DatabaseManager.h	Wed Dec 18 10:08:26 2024 +0100
@@ -223,7 +223,7 @@
         Execute(parameters);
       }
 
-      virtual void Execute(const Dictionary& parameters);
+      virtual void Execute(const Dictionary& parameters) ORTHANC_OVERRIDE;
 
       void ExecuteWithoutResult()
       {
@@ -255,7 +255,7 @@
         Execute(parameters);
       }
 
-      virtual void Execute(const Dictionary& parameters);
+      virtual void Execute(const Dictionary& parameters) ORTHANC_OVERRIDE;
 
       void ExecuteWithoutResult()
       {
diff -r 0aaeae85be08 -r d79ba6cbf0ee Framework/Plugins/IndexBackend.cpp
--- a/Framework/Plugins/IndexBackend.cpp	Tue Dec 17 20:33:12 2024 +0100
+++ b/Framework/Plugins/IndexBackend.cpp	Wed Dec 18 10:08:26 2024 +0100
@@ -2164,7 +2164,7 @@
     }
     
   public:
-    LookupFormatter(Dialect dialect) :
+    explicit LookupFormatter(Dialect dialect) :
       dialect_(dialect),
       count_(0)
     {
diff -r 0aaeae85be08 -r d79ba6cbf0ee Framework/Plugins/IndexConnectionsPool.cpp
--- a/Framework/Plugins/IndexConnectionsPool.cpp	Tue Dec 17 20:33:12 2024 +0100
+++ b/Framework/Plugins/IndexConnectionsPool.cpp	Wed Dec 18 10:08:26 2024 +0100
@@ -55,10 +55,9 @@
     {
       if (boost::posix_time::second_clock::local_time() - lastInvocation >= that->housekeepingDelay_)
       {
-        Accessor accessor(*that);
-
         try
         {
+          Accessor accessor(*that);
           accessor.GetBackend().PerformDbHousekeeping(accessor.GetManager());
         }
         catch (Orthanc::OrthancException& e)
diff -r 0aaeae85be08 -r d79ba6cbf0ee MySQL/Plugins/MySQLIndex.h
--- a/MySQL/Plugins/MySQLIndex.h	Tue Dec 17 20:33:12 2024 +0100
+++ b/MySQL/Plugins/MySQLIndex.h	Wed Dec 18 10:08:26 2024 +0100
@@ -35,7 +35,7 @@
     bool                   clearAll_;
 
   protected:
-    virtual bool HasChildCountTable() const
+    virtual bool HasChildCountTable() const ORTHANC_OVERRIDE
     {
       return false;
     }
diff -r 0aaeae85be08 -r d79ba6cbf0ee Odbc/Plugins/OdbcIndex.h
--- a/Odbc/Plugins/OdbcIndex.h	Tue Dec 17 20:33:12 2024 +0100
+++ b/Odbc/Plugins/OdbcIndex.h	Wed Dec 18 10:08:26 2024 +0100
@@ -35,7 +35,7 @@
     std::string  connectionString_;
     
   protected:
-    virtual bool HasChildCountTable() const
+    virtual bool HasChildCountTable() const ORTHANC_OVERRIDE
     {
       return false;
     }
diff -r 0aaeae85be08 -r d79ba6cbf0ee PostgreSQL/Plugins/PostgreSQLIndex.cpp
--- a/PostgreSQL/Plugins/PostgreSQLIndex.cpp	Tue Dec 17 20:33:12 2024 +0100
+++ b/PostgreSQL/Plugins/PostgreSQLIndex.cpp	Wed Dec 18 10:08:26 2024 +0100
@@ -549,11 +549,6 @@
   {
     std::string sql;
 
-    std::vector<std::string> resourceIds;
-    std::vector<std::string> groups;
-    std::vector<std::string> elements;
-    std::vector<std::string> values;
-
     Dictionary args;
     
     for (uint32_t i = 0; i < count; i++)