# HG changeset patch # User Sebastien Jodogne # Date 1754668879 -7200 # Node ID c1b73bf5c1223cb97f8804c4c48350a8ebd7d2f4 # Parent 004d853bdf6929609f24ded6cf9a2894032b5b30 removed connectionsMutex_ from BaseIndexConnectionsPool as it is defined in subclasses diff -r 004d853bdf69 -r c1b73bf5c122 Framework/Plugins/BaseIndexConnectionsPool.h --- a/Framework/Plugins/BaseIndexConnectionsPool.h Fri Aug 08 17:51:05 2025 +0200 +++ b/Framework/Plugins/BaseIndexConnectionsPool.h Fri Aug 08 18:01:19 2025 +0200 @@ -37,10 +37,8 @@ class BaseIndexConnectionsPool : public boost::noncopyable { protected: - std::unique_ptr backend_; OrthancPluginContext* context_; - boost::mutex connectionsMutex_; bool housekeepingContinue_; boost::thread housekeepingThread_; diff -r 004d853bdf69 -r c1b73bf5c122 Framework/Plugins/IndexUnitTests.h --- a/Framework/Plugins/IndexUnitTests.h Fri Aug 08 17:51:05 2025 +0200 +++ b/Framework/Plugins/IndexUnitTests.h Fri Aug 08 18:01:19 2025 +0200 @@ -785,13 +785,12 @@ // column in "ServerProperties" is "TEXT" instead of "LONGTEXT" db.SetGlobalProperty(*manager, "some-server", Orthanc::GlobalProperty_DatabaseInternal8, longProperty.c_str()); - std::string tmp; - ASSERT_TRUE(db.LookupGlobalProperty(tmp, *manager, MISSING_SERVER_IDENTIFIER, Orthanc::GlobalProperty_DatabaseInternal8)); - ASSERT_EQ(longProperty, tmp); + ASSERT_TRUE(db.LookupGlobalProperty(s, *manager, MISSING_SERVER_IDENTIFIER, Orthanc::GlobalProperty_DatabaseInternal8)); + ASSERT_EQ(longProperty, s); - tmp.clear(); - ASSERT_TRUE(db.LookupGlobalProperty(tmp, *manager, "some-server", Orthanc::GlobalProperty_DatabaseInternal8)); - ASSERT_EQ(longProperty, tmp); + s.clear(); + ASSERT_TRUE(db.LookupGlobalProperty(s, *manager, "some-server", Orthanc::GlobalProperty_DatabaseInternal8)); + ASSERT_EQ(longProperty, s); } for (size_t level = 0; level < 4; level++)