# HG changeset patch
# User Alain Mazy <am@osimis.io>
# Date 1709736969 -3600
# Node ID 694d1b551cbedaa3744e0cfc9242b48f9461a201
# Parent  0064a54745e129b2b37cf0731c5cb8f454f7ab48
ODBC MaximumConnectionRetries

diff -r 0064a54745e1 -r 694d1b551cbe Odbc/NEWS
--- a/Odbc/NEWS	Wed Mar 06 12:27:48 2024 +0100
+++ b/Odbc/NEWS	Wed Mar 06 15:56:09 2024 +0100
@@ -6,6 +6,7 @@
 * Compatibility with Orthanc SDK 1.12.0 (communications between the
   Orthanc core and the database plugin using Google Protocol Buffers)
 * Now detecting communication link failure with the DB and retrying to connect.
+* Fixed "MaximumConnectionRetries" configuration that was not taken into account.
 
 
 Release 1.1 (2021-12-06)
diff -r 0064a54745e1 -r 694d1b551cbe Odbc/Plugins/IndexPlugin.cpp
--- a/Odbc/Plugins/IndexPlugin.cpp	Wed Mar 06 12:27:48 2024 +0100
+++ b/Odbc/Plugins/IndexPlugin.cpp	Wed Mar 06 15:56:09 2024 +0100
@@ -101,7 +101,7 @@
     {
       const std::string connectionString = odbc.GetStringValue("IndexConnectionString", "");
       const unsigned int countConnections = odbc.GetUnsignedIntegerValue("IndexConnectionsCount", 1);
-      const unsigned int maxConnectionRetries = odbc.GetUnsignedIntegerValue("MaxConnectionRetries", 10);
+      const unsigned int maxConnectionRetries = odbc.GetUnsignedIntegerValue("MaximumConnectionRetries", 10);
       const unsigned int connectionRetryInterval = odbc.GetUnsignedIntegerValue("ConnectionRetryInterval", 5);
 
       if (connectionString.empty())
diff -r 0064a54745e1 -r 694d1b551cbe TODO
--- a/TODO	Wed Mar 06 12:27:48 2024 +0100
+++ b/TODO	Wed Mar 06 15:56:09 2024 +0100
@@ -10,9 +10,6 @@
 * Performance of joins in LookupResources: Create cached statement for
   LookupResources, that are grouped to search up to, say, 10 tags,
   instead of recompiling for each request
-* Check that "MaximumConnectionRetries" is also used when trying to
-  reconnect at the DB when the connection is lost while running.
-  At least with ODBC, this is not happening.
 
 ---------------------
 Common - Storage area