# HG changeset patch
# User Sebastien Jodogne <s.jodogne@gmail.com>
# Date 1754927458 -7200
# Node ID 691af3fc15c5b4343c3b5a3c7e8f9c32fd00fd2d
# Parent  9734488b55c0b9be20e7349e5bb3cf27725a2eaf
cppcheck

diff -r 9734488b55c0 -r 691af3fc15c5 Framework/Plugins/BaseIndexConnectionsPool.h
--- a/Framework/Plugins/BaseIndexConnectionsPool.h	Mon Aug 11 15:20:16 2025 +0200
+++ b/Framework/Plugins/BaseIndexConnectionsPool.h	Mon Aug 11 17:50:58 2025 +0200
@@ -46,8 +46,7 @@
 
     static void HousekeepingThread(BaseIndexConnectionsPool* that);
 
-    virtual void PerformPoolHousekeeping()
-    {}
+    virtual void PerformPoolHousekeeping() = 0;
 
     void StartHousekeepingThread();
 
diff -r 9734488b55c0 -r 691af3fc15c5 Framework/Plugins/DynamicIndexConnectionsPool.h
--- a/Framework/Plugins/DynamicIndexConnectionsPool.h	Mon Aug 11 15:20:16 2025 +0200
+++ b/Framework/Plugins/DynamicIndexConnectionsPool.h	Mon Aug 11 17:50:58 2025 +0200
@@ -48,7 +48,6 @@
     void CleanupOldConnections();
 
   protected:
-
     virtual DatabaseManager* GetConnection() ORTHANC_OVERRIDE;
     
     virtual void ReleaseConnection(DatabaseManager* manager) ORTHANC_OVERRIDE;
@@ -66,6 +65,5 @@
                                  const std::list<IdentifierTag>& identifierTags) ORTHANC_OVERRIDE;
 
     virtual void CloseConnections() ORTHANC_OVERRIDE;
-
   };
 }
diff -r 9734488b55c0 -r 691af3fc15c5 Framework/Plugins/IndexConnectionsPool.h
--- a/Framework/Plugins/IndexConnectionsPool.h	Mon Aug 11 15:20:16 2025 +0200
+++ b/Framework/Plugins/IndexConnectionsPool.h	Mon Aug 11 17:50:58 2025 +0200
@@ -34,6 +34,12 @@
 
 namespace OrthancDatabases
 {
+  /**
+   * This class corresponds to "IndexConnectionsPool.h" in
+   * OrthancPostgreSQL-8.0, but with a base class that is shared with
+   * a new class "DynamicIndexConnectionsPool":
+   * https://orthanc.uclouvain.be/hg/orthanc-databases/file/OrthancPostgreSQL-8.0/Framework/Plugins/IndexConnectionsPool.h
+   **/
   class IndexConnectionsPool : public BaseIndexConnectionsPool
   {
   private:
@@ -45,7 +51,6 @@
     Orthanc::SharedMessageQueue    availableConnections_;
 
   protected:
-
     virtual DatabaseManager* GetConnection() ORTHANC_OVERRIDE;
     
     virtual void ReleaseConnection(DatabaseManager* manager) ORTHANC_OVERRIDE;