Mercurial > hg > orthanc-databases
diff Framework/MySQL/MySQLDatabase.cpp @ 186:6fe74f9a516e
cppcheck
author | Sebastien Jodogne <s.jodogne@gmail.com> |
---|---|
date | Wed, 16 Dec 2020 15:05:19 +0100 |
parents | 0632c2408af3 |
children | 0b78198c28d6 |
line wrap: on
line diff
--- a/Framework/MySQL/MySQLDatabase.cpp Wed Dec 16 13:59:17 2020 +0100 +++ b/Framework/MySQL/MySQLDatabase.cpp Wed Dec 16 15:05:19 2020 +0100 @@ -326,14 +326,14 @@ query.SetType("lock", ValueType_Utf8String); - MySQLStatement statement(*this, query); - Dictionary args; args.SetUtf8Value("lock", prefix + "." + lock); bool success; { + MySQLStatement statement(*this, query); + MySQLTransaction t(*this); std::unique_ptr<IResult> result(t.Execute(statement, args)); @@ -460,7 +460,7 @@ return (!result->IsDone() && result->GetFieldsCount() == 1 && result->GetField(0).GetType() == ValueType_Integer64 && - dynamic_cast<const Integer64Value&>(result->GetField(0)).GetValue() == 1); + dynamic_cast<const Integer64Value&>(result->GetField(0)).GetValue() != 0); } @@ -530,7 +530,7 @@ } public: - MySQLImplicitTransaction(MySQLDatabase& db) : + explicit MySQLImplicitTransaction(MySQLDatabase& db) : db_(db) { }