diff Framework/Common/DatabaseManager.h @ 29:2fb9cd42af14

cppcheck
author Sebastien Jodogne <s.jodogne@gmail.com>
date Mon, 16 Jul 2018 15:20:35 +0200
parents b2ff1cd2907a
children 714c5d2bee76
line wrap: on
line diff
--- a/Framework/Common/DatabaseManager.h	Mon Jul 16 14:48:43 2018 +0200
+++ b/Framework/Common/DatabaseManager.h	Mon Jul 16 15:20:35 2018 +0200
@@ -57,7 +57,7 @@
     void ReleaseImplicitTransaction();
 
   public:
-    DatabaseManager(IDatabaseFactory* factory);  // Takes ownership
+    explicit DatabaseManager(IDatabaseFactory* factory);  // Takes ownership
     
     ~DatabaseManager()
     {
@@ -93,7 +93,7 @@
       bool                                 committed_;
 
     public:
-      Transaction(DatabaseManager& manager);
+      explicit Transaction(DatabaseManager& manager);
 
       ~Transaction();
 
@@ -114,8 +114,8 @@
     class CachedStatement : public boost::noncopyable
     {
     private:
+      DatabaseManager&                     manager_;
       boost::recursive_mutex::scoped_lock  lock_;
-      DatabaseManager&                     manager_;
       IDatabase&                           database_;
       StatementLocation                    location_;
       ITransaction&                        transaction_;