Mercurial > hg > orthanc-databases
annotate MySQL/Plugins/MySQLStorageArea.cpp @ 135:e26690365c25
MySQL: Added an advisory lock to avoid race conditions during database setup
author | Sebastien Jodogne <s.jodogne@gmail.com> |
---|---|
date | Wed, 08 May 2019 21:09:18 +0200 |
parents | 714c5d2bee76 |
children | 52b3859ee0b7 |
rev | line source |
---|---|
17 | 1 /** |
2 * Orthanc - A Lightweight, RESTful DICOM Store | |
3 * Copyright (C) 2012-2016 Sebastien Jodogne, Medical Physics | |
4 * Department, University Hospital of Liege, Belgium | |
67 | 5 * Copyright (C) 2017-2019 Osimis S.A., Belgium |
17 | 6 * |
7 * This program is free software: you can redistribute it and/or | |
8 * modify it under the terms of the GNU Affero General Public License | |
9 * as published by the Free Software Foundation, either version 3 of | |
10 * the License, or (at your option) any later version. | |
11 * | |
12 * This program is distributed in the hope that it will be useful, but | |
13 * WITHOUT ANY WARRANTY; without even the implied warranty of | |
14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
15 * Affero General Public License for more details. | |
16 * | |
17 * You should have received a copy of the GNU Affero General Public License | |
18 * along with this program. If not, see <http://www.gnu.org/licenses/>. | |
19 **/ | |
20 | |
21 | |
22 #include "MySQLStorageArea.h" | |
23 | |
24 #include "../../Framework/MySQL/MySQLDatabase.h" | |
25 #include "../../Framework/MySQL/MySQLTransaction.h" | |
26 | |
27 #include <Core/Logging.h> | |
28 | |
29 #include <boost/math/special_functions/round.hpp> | |
30 | |
31 | |
32 namespace OrthancDatabases | |
33 { | |
34 IDatabase* MySQLStorageArea::OpenInternal() | |
35 { | |
36 std::auto_ptr<MySQLDatabase> db(new MySQLDatabase(parameters_)); | |
37 | |
38 db->Open(); | |
39 | |
40 if (parameters_.HasLock()) | |
41 { | |
42 db->AdvisoryLock(43 /* some arbitrary constant */); | |
43 } | |
44 | |
135
e26690365c25
MySQL: Added an advisory lock to avoid race conditions during database setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
67
diff
changeset
|
45 /** |
e26690365c25
MySQL: Added an advisory lock to avoid race conditions during database setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
67
diff
changeset
|
46 * Try and acquire a transient advisory lock to protect the setup |
e26690365c25
MySQL: Added an advisory lock to avoid race conditions during database setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
67
diff
changeset
|
47 * of the database, because concurrent statements like "CREATE |
e26690365c25
MySQL: Added an advisory lock to avoid race conditions during database setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
67
diff
changeset
|
48 * TABLE" are not protected by transactions. |
e26690365c25
MySQL: Added an advisory lock to avoid race conditions during database setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
67
diff
changeset
|
49 * https://groups.google.com/d/msg/orthanc-users/yV3LSTh_TjI/h3PRApJFBAAJ |
e26690365c25
MySQL: Added an advisory lock to avoid race conditions during database setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
67
diff
changeset
|
50 **/ |
e26690365c25
MySQL: Added an advisory lock to avoid race conditions during database setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
67
diff
changeset
|
51 MySQLDatabase::TransientAdvisoryLock lock(*db, 44 /* some arbitrary constant */); |
e26690365c25
MySQL: Added an advisory lock to avoid race conditions during database setup
Sebastien Jodogne <s.jodogne@gmail.com>
parents:
67
diff
changeset
|
52 |
17 | 53 { |
54 MySQLTransaction t(*db); | |
55 | |
56 int64_t size; | |
57 if (db->LookupGlobalIntegerVariable(size, "max_allowed_packet")) | |
58 { | |
59 int mb = boost::math::iround(static_cast<double>(size) / | |
60 static_cast<double>(1024 * 1024)); | |
61 LOG(WARNING) << "Your MySQL server cannot " | |
62 << "store DICOM files larger than " << mb << "MB"; | |
63 LOG(WARNING) << " => Consider increasing \"max_allowed_packet\" " | |
64 << "in \"my.cnf\" if this limit is insufficient for your use"; | |
65 } | |
66 else | |
67 { | |
68 LOG(WARNING) << "Unable to auto-detect the maximum size of DICOM " | |
69 << "files that can be stored in this MySQL server"; | |
70 } | |
71 | |
72 if (clearAll_) | |
73 { | |
74 db->Execute("DROP TABLE IF EXISTS StorageArea", false); | |
75 } | |
76 | |
77 db->Execute("CREATE TABLE IF NOT EXISTS StorageArea(" | |
78 "uuid VARCHAR(64) NOT NULL PRIMARY KEY," | |
79 "content LONGBLOB NOT NULL," | |
80 "type INTEGER NOT NULL)", false); | |
81 | |
82 t.Commit(); | |
83 } | |
84 | |
85 return db.release(); | |
86 } | |
87 | |
88 | |
89 MySQLStorageArea::MySQLStorageArea(const MySQLParameters& parameters) : | |
90 StorageBackend(new Factory(*this)), | |
91 parameters_(parameters), | |
92 clearAll_(false) | |
93 { | |
94 } | |
95 } |