comparison Sphinx/source/faq/licensing.rst @ 361:84e3a2612c36

links to hg
author Sebastien Jodogne <s.jodogne@gmail.com>
date Mon, 30 Mar 2020 20:37:49 +0200
parents d217af5e6cb3
children 987fbbc2b59e
comparison
equal deleted inserted replaced
360:d217af5e6cb3 361:84e3a2612c36
232 acting as physical persons. If your company wishes to become 232 acting as physical persons. If your company wishes to become
233 contributor as a juridical person, please request a Corporate CLA at 233 contributor as a juridical person, please request a Corporate CLA at
234 the same e-mail address: ``orthanc-legal@osimis.io``. 234 the same e-mail address: ``orthanc-legal@osimis.io``.
235 235
236 236
237 .. _submitting_code:
238
237 Submitting code 239 Submitting code
238 ^^^^^^^^^^^^^^^ 240 ^^^^^^^^^^^^^^^
239 241
240 Once the CLA onboarding process has succeeded, use `Mercurial 242 Once the CLA onboarding process has succeeded, use `Mercurial
241 <https://en.wikipedia.org/wiki/Mercurial>`__ to fork the official 243 <https://en.wikipedia.org/wiki/Mercurial>`__ to fork the official
242 repository of interest from BitBucket. Here are the location of those 244 repository of interest from BitBucket. All the repositories are
243 repositories: 245 centralized on our `self-hosted Mercurial server
244 246 <https://hg.orthanc-server.com/>`__.
245 * The `Orthanc server <https://bitbucket.org/sjodogne/orthanc/src>`__. 247
246 248 A :ref:`dedicated page <repositories>` explains how to submit
247 * The `official plugins <https://bitbucket.org/sjodogne/>`__ originating from the University Hospital of Liège. 249 :ref:`simple patches <hg-patch>` or :ref:`full branches <hg-bundle>`.
248
249 * The `official plugins <https://bitbucket.org/osimis/>`__ originating from Osimis.
250
251 Once you have finished modifying the code in your forked repository,
252 issue a `pull request
253 <https://confluence.atlassian.com/bitbucket/tutorial-learn-about-bitbucket-pull-requests-774243385.html>`__.
254 250
255 **Some words of warning:** 251 **Some words of warning:**
256 252
257 * Please stick to the :ref:`coding style <coding-style>` of Orthanc. 253 * Please stick to the :ref:`coding style <coding-style>` of Orthanc.
258 254
276 Orthanc, as we must follow our `long-term roadmap 272 Orthanc, as we must follow our `long-term roadmap
277 <https://hg.orthanc-server.com/orthanc/file/default/TODO>`__. 273 <https://hg.orthanc-server.com/orthanc/file/default/TODO>`__.
278 274
279 * Unit testing is mandatory. Integration tests should be submitted to 275 * Unit testing is mandatory. Integration tests should be submitted to
280 the `dedicated repository 276 the `dedicated repository
281 <https://bitbucket.org/sjodogne/orthanc-tests/>`__. 277 <https://hg.orthanc-server.com/orthanc-tests/file/tip>`__.
282 278
283 * In the case of a doubt wrt. a potential contribution, please discuss 279 * In the case of a doubt wrt. a potential contribution, please discuss
284 it on the `Orthanc Users 280 it on the `Orthanc Users
285 <https://groups.google.com/forum/#!forum/orthanc-users>`__ 281 <https://groups.google.com/forum/#!forum/orthanc-users>`__
286 discussion group before starting the actual development. 282 discussion group before starting the actual development.