Mercurial > hg > orthanc-book
comparison Sphinx/source/faq/licensing.rst @ 204:76c76af97a2a
cont
author | Sebastien Jodogne <s.jodogne@gmail.com> |
---|---|
date | Tue, 12 Feb 2019 16:53:20 +0100 |
parents | b79ef7808f16 |
children | 0122c668f4ec |
comparison
equal
deleted
inserted
replaced
203:b79ef7808f16 | 204:76c76af97a2a |
---|---|
186 plugins. This includes new features and bugfixes. The way to | 186 plugins. This includes new features and bugfixes. The way to |
187 contribute to the internal code of the Orthanc ecosystem is | 187 contribute to the internal code of the Orthanc ecosystem is |
188 described in the sections below. | 188 described in the sections below. |
189 | 189 |
190 | 190 |
191 **Important:** You should always favor the :ref:`creation of a new | |
192 plugin <creating-plugins>` over modifications to the internal code | |
193 (see below)! | |
194 | |
195 | |
191 | 196 |
192 Contributor License Agreement | 197 Contributor License Agreement |
193 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | 198 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
194 | 199 |
195 It is necessary for the Orthanc project to make sure that the internal | 200 It is necessary for the Orthanc project to make sure that the internal |
257 may be modified, yet even rejected. A rejection might for instance | 262 may be modified, yet even rejected. A rejection might for instance |
258 occur if your contribution does not match the Orthanc roadmap, does | 263 occur if your contribution does not match the Orthanc roadmap, does |
259 not meet our high-quality code standards, or breaks backward | 264 not meet our high-quality code standards, or breaks backward |
260 compatibility. Please be sure that we warmly welcome and appreciate | 265 compatibility. Please be sure that we warmly welcome and appreciate |
261 your contributions, but be aware of the fact that we are quite | 266 your contributions, but be aware of the fact that we are quite |
262 strict, and that the review process might take time. | 267 strict, and that the review process might take time. This is why the |
268 recommended way of contributing to Orthanc is always by | |
269 :ref:`creating contributed plugins <creating-plugins>`. | |
270 | |
271 * Your pull requests should be kept **as small as possible**, and | |
272 should be focused on one very specific issue or feature. Large | |
273 architectural changes are reserved for the core development team of | |
274 Orthanc, as we must follow our `long-term roadmap | |
275 <https://bitbucket.org/sjodogne/orthanc/src/default/TODO>`__. | |
276 | |
277 * Unit testing is mandatory. Integration tests should be submitted to | |
278 the `dedicated repository | |
279 <http://bitbucket.org/sjodogne/orthanc-tests/>`__. | |
263 | 280 |
264 * In the case of a doubt wrt. a potential contribution, please discuss | 281 * In the case of a doubt wrt. a potential contribution, please discuss |
265 it on the `Orthanc Users | 282 it on the `Orthanc Users |
266 <https://groups.google.com/forum/#!forum/orthanc-users>`__ | 283 <https://groups.google.com/forum/#!forum/orthanc-users>`__ |
267 discussion group before starting the actual development. | 284 discussion group before starting the actual development. |