Mercurial > hg > orthanc-book
comparison Sphinx/source/faq/licensing.rst @ 627:53992cb7fa7f
c++03
| author | Sebastien Jodogne <s.jodogne@gmail.com> |
|---|---|
| date | Sat, 06 Mar 2021 11:35:51 +0100 |
| parents | 610e6be26a71 |
| children | 41bae819d80b |
comparison
equal
deleted
inserted
replaced
| 626:68c6c251e348 | 627:53992cb7fa7f |
|---|---|
| 259 A :ref:`dedicated page <repositories>` explains how to submit | 259 A :ref:`dedicated page <repositories>` explains how to submit |
| 260 :ref:`simple patches <hg-patch>` or :ref:`full branches <hg-bundle>`. | 260 :ref:`simple patches <hg-patch>` or :ref:`full branches <hg-bundle>`. |
| 261 | 261 |
| 262 **Some words of warning:** | 262 **Some words of warning:** |
| 263 | 263 |
| 264 * Please stick to the :ref:`coding style <coding-style>` of Orthanc. | |
| 265 | |
| 266 * It is your responsibility to make sure that you have the | 264 * It is your responsibility to make sure that you have the |
| 267 intellectual property over all the source code you commit into | 265 intellectual property over all the source code you commit into |
| 268 Orthanc. | 266 Orthanc. |
| 269 | |
| 270 * All the contributions will be carefully reviewed. Some contributions | |
| 271 may be modified, yet even rejected. A rejection might for instance | |
| 272 occur if your contribution does not match the Orthanc roadmap, does | |
| 273 not meet our high-quality code standards, or breaks backward | |
| 274 compatibility. Please be sure that we warmly welcome and appreciate | |
| 275 your contributions, but be aware of the fact that we are quite | |
| 276 strict, and that the review process might take time. This is why the | |
| 277 recommended way of contributing to Orthanc is always by | |
| 278 :ref:`creating contributed plugins <creating-plugins>`. | |
| 279 | |
| 280 * Your pull requests should be kept **as small as possible**, and | |
| 281 should be focused on one very specific issue or feature. Large | |
| 282 architectural changes are reserved for the core development team of | |
| 283 Orthanc, as we must follow our `long-term roadmap | |
| 284 <https://hg.orthanc-server.com/orthanc/file/default/TODO>`__. | |
| 285 | |
| 286 * Unit testing is mandatory. Integration tests should be submitted to | |
| 287 the `dedicated repository | |
| 288 <https://hg.orthanc-server.com/orthanc-tests/file/default>`__. | |
| 289 | 267 |
| 290 * In the case of a doubt wrt. a potential contribution, please discuss | 268 * In the case of a doubt wrt. a potential contribution, please discuss |
| 291 it on the `Orthanc Users | 269 it on the `Orthanc Users |
| 292 <https://groups.google.com/forum/#!forum/orthanc-users>`__ | 270 <https://groups.google.com/forum/#!forum/orthanc-users>`__ |
| 293 discussion group before starting the actual development. | 271 discussion group before starting the actual development. |