# HG changeset patch
# User Alain Mazy <am@orthanc.team>
# Date 1734709090 -3600
# Node ID ae7a37e320e7d3d426a2d21072a9d6244838a3fa
# Parent  3c56c3f0059a40b2ab5ef958f8fc78c5b0bfd05e
don't throw if WebServiceSettingsRolesUrl is not defined

diff -r 3c56c3f0059a -r ae7a37e320e7 NEWS
--- a/NEWS	Mon Sep 23 12:43:33 2024 +0200
+++ b/NEWS	Fri Dec 20 16:38:10 2024 +0100
@@ -2,6 +2,7 @@
 ===============================
 
 * Fix forbidden access when the PatientID and StudyInstanceUID are identical.
+* Fix an error when WebServiceSettingsRolesUrl is not defined.
 
 
 2024-07-03 - v 0.8.1
diff -r 3c56c3f0059a -r ae7a37e320e7 Plugin/AuthorizationWebService.cpp
--- a/Plugin/AuthorizationWebService.cpp	Mon Sep 23 12:43:33 2024 +0200
+++ b/Plugin/AuthorizationWebService.cpp	Fri Dec 20 16:38:10 2024 +0100
@@ -456,7 +456,8 @@
   {
     if (settingsRolesUrl_.empty())
     {
-      throw Orthanc::OrthancException(Orthanc::ErrorCode_BadRequest, "Can not get settings-roles if the 'WebServiceSettingsRolesUrl' is not configured");
+      LOG(INFO) << "Can not get settings-roles if the 'WebServiceSettingsRolesUrl' is not configured";
+      return false;
     }
 
     Orthanc::WebServiceParameters authWebservice;
diff -r 3c56c3f0059a -r ae7a37e320e7 Plugin/DefaultConfiguration.json
--- a/Plugin/DefaultConfiguration.json	Mon Sep 23 12:43:33 2024 +0200
+++ b/Plugin/DefaultConfiguration.json	Fri Dec 20 16:38:10 2024 +0100
@@ -22,6 +22,9 @@
         // The URL of the auth webservice route implementing token decoding (optional)
         // "WebServiceTokenDecoderUrl": "http://change-me:8000/tokens/decode"
 
+        // The URL of the auth webservice route implementing roles assignements (optional)
+        // "WebServiceSettingsRolesUrl": "http://change-me:8000/settings/roles"
+
         // The username and password to connect to the webservice (optional)
         //"WebServiceUsername": "change-me",
         //"WebServicePassword": "change-me",