Bug 204 - Build fails with dcmtk-3.6.7: error: use of undeclared identifier 'TCS_ok'
Summary: Build fails with dcmtk-3.6.7: error: use of undeclared identifier 'TCS_ok'
Status: RESOLVED FIXED
Alias: None
Product: Orthanc
Classification: Unclassified
Component: Orthanc Core (show other bugs)
Version: unspecified
Hardware: PC Other
: --- enhancement
Assignee: Sébastien Jodogne
URL:
: 206 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-05-01 00:16 CEST by yuri
Modified: 2022-05-16 17:50 CEST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yuri 2022-05-01 00:16:16 CEST 
Orthanc-1.9.7 fails with dcmtk-3.6.7:

/wrkdirs/usr/ports/science/orthanc/work/Orthanc-1.9.7/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp:109:118: error: use of undeclared identifier 'TCS_ok'
      if (tls->addTrustedCertificateFile(trustedCertificatesPath.c_str(), DCF_Filetype_PEM /*opt_keyFileFormat*/) != TCS_ok)
                                                                                                                     ^
/wrkdirs/usr/ports/science/orthanc/work/Orthanc-1.9.7/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp:115:104: error: use of undeclared identifier 'TCS_ok'
      if (tls->setPrivateKeyFile(ownPrivateKeyPath.c_str(), DCF_Filetype_PEM /*opt_keyFileFormat*/) != TCS_ok)
                                                                                                       ^
/wrkdirs/usr/ports/science/orthanc/work/Orthanc-1.9.7/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp:121:106: error: use of undeclared identifier 'TCS_ok'
      if (tls->setCertificateFile(ownCertificatePath.c_str(), DCF_Filetype_PEM /*opt_keyFileFormat*/) != TCS_ok)
                                                                                                         ^
/wrkdirs/usr/ports/science/orthanc/work/Orthanc-1.9.7/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp:134:72: error: use of undeclared identifier 'TCS_ok'
      if (tls->setTLSProfile(TSP_Profile_BCP195 /*opt_tlsProfile*/) != TCS_ok)
                                                                       ^
/wrkdirs/usr/ports/science/orthanc/work/Orthanc-1.9.7/OrthancFramework/Sources/DicomNetworking/Internals/DicomTls.cpp:139:11: error: value of type 'OFCondition' is not contextually convertible to 'bool'
      if (tls->activateCipherSuites())
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~


clang-13
FreeBSD 13
Comment 1 Sébastien Jodogne 2022-05-04 11:49:37 CEST 
Thanks for the report. It however appears that DCMTK 3.6.7 is not an official release yet:
https://dicom.offis.de/dcmtk.php.en

This issue will be taken into consideration when an official release is available.
Comment 2 Sébastien Jodogne 2022-05-04 17:14:26 CEST 
Here is a patch that has been uploaded to Debian Unstable/Sid to resolve the same issue:
https://salsa.debian.org/med-team/orthanc/-/commit/3a22d6b71d211a4d9262f494afe66f7a7b5df667

It should be possible to transpose it as such to FreeBSD 13.
Comment 3 Sébastien Jodogne 2022-05-04 17:31:50 CEST 
The mainline of Orthanc has been fixed by the following changeset:
https://hg.orthanc-server.com/orthanc/rev/1f93dc290628
Comment 4 yuri 2022-05-16 17:50:48 CEST 
*** Bug 206 has been marked as a duplicate of this bug. ***