Bug 4

Summary:	C-Store Association not Renegotiated on Specific-to-specific transfer syntax change
Product:	Orthanc	Reporter:	Sébastien Jodogne <s.jodogne>
Component:	Orthanc Core	Assignee:	Sébastien Jodogne <s.jodogne>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	---
Version:	unspecified
Hardware:	All
OS:	All

Description Sébastien Jodogne 2020-06-29 15:11:07 CEST

[BitBucket user: Alex Rothberg]
[BitBucket date: 2015-09-18.15:08:23]

This code does not seem to deal with the case where the needed TransferSyntax goes from one specific instance to another:

```
#!c++

    // Determine whether a new presentation context must be
    // negotiated, depending on the transfer syntax of this instance
    DcmXfer xfer(dcmff.getDataset()->getOriginalXfer());
    const std::string syntax(xfer.getXferID());
    bool isGeneric = IsGenericTransferSyntax(syntax);

    if (isGeneric ^ IsGenericTransferSyntax(connection.GetPreferredTransferSyntax()))
    {
      // Making a generic-to-specific or specific-to-generic change of
      // the transfer syntax. Renegotiate the connection.
      LOG(INFO) << "Change in the transfer syntax: the C-Store associated must be renegotiated";

      if (isGeneric)
      {
        connection.ResetPreferredTransferSyntax();
      }
      else
      {
        connection.SetPreferredTransferSyntax(syntax);
      }
    }
```

Comment 1 Sébastien Jodogne 2020-06-29 15:18:38 CEST

[BitBucket user: Sébastien Jodogne]
[BitBucket date: 2015-10-06.14:33:26]

Fix issue 4 (C-Store Association not renegotiated on Specific-to-specific transfer syntax change)

→ https://hg.orthanc-server.com/orthanc/changeset/7dae55228b16