Bug 184

Created attachment 115 [details]
from storescu

Created attachment 116 [details]
from orthanc

After first analysis, the file from Orthanc is in implicit transfer syntax while the one from dcmsend/storescu is in explicit transfer syntax.

Orthanc JSON file handles the private tags correctly only with the explicit file.

Also note that Orthanc does not seem to add the "PrivateCreator" tag correctly at the beginning of the private group.

$ dcmdump storescu.dcm:
...
(0028,1054) LO [HU]                                     #   2, 1 RescaleType
... missing PrivateCreator tag here ...
(6161,1043) AE [127.22.0.1]                             #  10, 1 Unknown Tag & Data
(6161,1044) AE [STORESCU]                               #   8, 1 Unknown Tag & Data
(6161,1045) AE [ANY-SCP]                                #   8, 1 Unknown Tag & Data

Link to the original discussion:
https://groups.google.com/forum/#!msg/orthanc-users/kdLXS_VCeQk/rkXCA6TlBgAJ

Here is a much more direct way to reproduce, without having two instances of Orthanc and without using Docker.

(1) Take the files "lua/on_stored_instance.lua" and "3c5c2db6-b668-42bb-ab83-24eac780d805.dcm" out of the "reproduce.tar.gz" archive provided by Nick.

(2) Start Orthanc with the following adapted configuration file:

$ cat <<EOF > anonymizer.json
{
  "LuaScripts" : [ "on_stored_instance.lua" ],
  "OverwriteInstances" : true,
  "Dictionary": {
    "6161,1043" : [ "AE", "RemoteIp", 1, 1, "GenesisCare" ],
    "6161,1044" : [ "AE", "RemoteAet", 1, 1, "GenesisCare" ],
    "6161,1045" : [ "AE", "CalledAet", 1, 1, "GenesisCare" ],
    "6161,1046" : [ "LO", "Username", 1, 1, "GenesisCare" ]
  }
}
EOF
$ ./Orthanc anonymizer.json

(3) Use storescu from DCMTK to upload and anonymize the sample DICOM file, as follows:

$ storescu -xe localhost 4242 3c5c2db6-b668-42bb-ab83-24eac780d805.dcm 
$ storescu -xi localhost 4242 3c5c2db6-b668-42bb-ab83-24eac780d805.dcm

(4) Observations vs. expectations:

In the first flavor, Orthanc receives a file encoded using the "Little Endian Explicit" transfer syntax => the content of the tags is displayed.

In the second flavor, Orthanc receives a file encoded using the "Little Endian Implicit" transfer syntax => the tags are reported as "null".

In both flavors, the name of the tags are reported as "Unknown Tag & Data".


Now that I'm able to reproduce in a developer-friendly environment, I'll have a deeper look at the report.

It turns out that the problem is not in Orthanc, but in your Lua script. Indeed, the tag "6161,0010" is missing, but it must be present as it is used to determine the private creator for your tags.

Here is a fixed Orthanc configuration:

{
  "LuaScripts" : [ "on_stored_instance.lua" ],
  "OverwriteInstances" : true,
  "Dictionary": {
    "6161,0010" : [ "LO", "GenesisCare", 1, 1, "GenesisCare" ],  // <== NEW
    "6161,1043" : [ "AE", "RemoteIp", 1, 1, "GenesisCare" ],
    "6161,1044" : [ "AE", "RemoteAet", 1, 1, "GenesisCare" ],
    "6161,1045" : [ "AE", "CalledAet", 1, 1, "GenesisCare" ],
    "6161,1046" : [ "LO", "Username", 1, 1, "GenesisCare" ]
  }
}

Here is a fixed Lua script (excerpt):

      -- The tags to be replaced
      local replace = {}
      replace['6161,0010'] = 'GenesisCare'  -- <== NEW
      replace['CalledAet'] = trim(origin["CalledAet"])
      replace['RemoteAet'] = trim(origin["RemoteAet"])
      replace['RemoteIp'] = trim(origin["RemoteIp"])

And here is the result (both "storescu -xe" and "storescu -xi" lead to the same log):

   "6161,0010" : {
      "Name" : "PrivateCreator",
      "Type" : "String",
      "Value" : "GenesisCare"
   },
   "6161,1043" : {
      "Name" : "RemoteIp",
      "PrivateCreator" : "GenesisCare",
      "Type" : "String",
      "Value" : "127.0.0.1"
   },
   "6161,1044" : {
      "Name" : "RemoteAet",
      "PrivateCreator" : "GenesisCare",
      "Type" : "String",
      "Value" : "STORESCU"
   },
   "6161,1045" : {
      "Name" : "CalledAet",
      "PrivateCreator" : "GenesisCare",
      "Type" : "String",
      "Value" : "ANY-SCP"
   },