Issue67

Title static compilation of Orthanc 1.3.0 fails because of dcmtk 3.6.2 errors (... +0) [fix included]
Priority bug Status resolved
Superseder Nosy List admin
Assigned To
Keywords Orthanc Core

Created on 2017-09-13.11:20:36 by admin, last changed by admin.

Messages
msg310 (view) Author: admin Date: 2017-09-13.11:20:36
[BitBucket user: asch99]
[BitBucket date: 2017-09-13.09:20:36]

Static compilation of Orthanc 1.3.0 fails,  at least on Ubuntu 17.04 (and Fedora 25 as reported by somebody else on http://forum.dcmtk.org/viewtopic.php?f=3&t=4584).

Steps to reproduce:

```
#!python

  cmake -DSTATIC_BUILD=ON -DCMAKE_BUILD_TYPE=Release

```

It appears that the new DCMTK flag WITH_THREADS does not make it to the CMake files.
 
A simple fix (tested by me) would be the add the line

```
#!python

    SET(DCMTK_WITH_THREADS ON)

```

after the line 

```
#!python

    add_definitions(-DDCMTK_INSIDE_LOG4CPLUS=1)


```
at the beginning of
Resources/CMake/DcmtkConfiguration.cmake
msg311 (view) Author: admin Date: 2017-09-13.14:29:09
[BitBucket user: Sébastien Jodogne]
[BitBucket date: 2017-09-13.12:29:09]

Hello, thanks for the report! This issue was already fixed a few weeks ago in the mainline of Orthanc with the following changeset: https://hg.orthanc-server.com/orthanc/changeset/c33ff8a7ffa94900017f323ab26192267fd3ff4e
History
Date User Action Args
2026-07-29 15:51:21admincreate